GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — ci: make doc-check reviews smaller and start a new chat per run by bpmct · Pull Request #32061 · coder/coder Conversation
Member
doc-check reviews are too big and too slow for the local model, and the job result does not match the review result. From 2026-11-04 to 11-11 (week report):
ChangesSkill (
Workflow (
Why wait and not end the job when the chat starts: the job has to outlive the chat to stop the workspace when the review ends, and the per-PR concurrency group only keeps two reviews out of one workspace while the job is running. Ending the job early would lose both. The cost is a GitHub-hosted runner that polls for as long as the review takes. Not tested on live trafficI checked this with actionlint, zizmor, markdownlint, and a local run of the prompt step with a fake Coder API. It has not run against dogfood. To evaluate it, re-run doc-check on the same 27 PRs from the week report and compare: chats started, time to verdict, job result, and how many of the 17/3/3/4 verdicts change. Also check #31790 and #31849 together, and #31808 for style findings that block. Overlaps: #31720 changes the same workflow to cancel the run in progress and stop the review chat. #31649 (draft) goes the other way in the skill, with more, narrower sub-agents. Only one of them should merge as is. Decision log
Generated by Coder Agents on behalf of @bpmct.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe skill runs its seven personas in three groups (facts, reader, language). Each group loads each docs/.style rule page once. A change under 150 docs-relevant lines runs the groups inline with no sub-agents. Verification uses one verifier for 5 or fewer findings and never more than two. A style finding that leaves the meaning unchanged is a suggestion and never blocks. A PR in a stack or backport family checks the doc-check verdict its siblings got and keeps it for the same surface, or says why it differs. The workflow starts a new chat for each run in the PR's review workspace, and passes the previous run's trace in the prompt. It waits up to 5 hours, and a review that is still running at that point no longer fails the job. This branch was previously deployed1 inactive deployment
main
—
305671a1
Deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersAt least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |