GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: make ask_user_question option descriptions optional by mafredri · Pull Request #32082 · coder/coder

Conversation

mafredri commented Nov 12, 2026

Copy link

Copy Markdown

Member

ask_user_question required a description on every option. When a label already says everything, the model had to invent one, and the question card showed "No description provided." when it sent an empty string.

The option schema now requires only label, validation accepts an option without a description, and the tool result omits an empty one. The question card shows such an option as its label alone. Options with a description look as before.

Verified with: go test ./coderd/x/chatd/chattool/ -run AskUserQuestion, the AskUserQuestionTool Vitest and Storybook tests (new story OptionsWithoutDescriptions), tsc and make pre-commit. The new tests fail when the validation check, the omitempty tag or the placeholder is restored.

Refs CODAGT-1460

Decision log

Split from the async questions work so it can merge on its own. It changes the tool as it is on main and needs no experiment.
The tool description is unchanged. The description property's own description tells the model to omit it when the label needs no explanation.
A description that is only whitespace is accepted and returned unchanged; the question card trims it and shows the label alone.
Not in this PR: Markdown in questions and options, and any change to the form's layout.

🤖 Created with the help of Coder Agents.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mafredri added 4 commits

November 12, 2026 12:37


          feat(coderd/x/chatd/chattool): make ask_user_question option descript…

…ions optional

Allow models to omit detail when the option label is sufficient, without
returning empty description fields to callers.


          feat(site/src/pages/AgentsPage): show ask_user_question options witho…

58522d8

…ut a description

Show labels without placeholder copy when an option needs no explanation.
Keep described options and the Other row unchanged.


          refactor(coderd/x/chatd/chattool): improve readability of optional de…

681cfc8

…scription test

The test compared the tool result with a copy of its input, both as
long single-line literals, so a reader could not see what it checked.
It now writes the input as a multi-line raw string, decodes the result
and asserts directly that the first option keeps its description and
the second option has no description key.


          refactor(site/src/pages/AgentsPage): improve readability of question …

0e9afa7

…card stories

OptionsWithoutDescriptions sat between InteractiveSingleQuestion and
InteractiveSingleQuestionOther and split that group. It now follows
the last InteractiveSingleQuestion story. The story is unchanged.

mafredri temporarily deployed to main

November 12, 2026 12:38

— with

GitHub Actions Inactive

mafredri temporarily deployed to main

November 12, 2026 12:38

— with

GitHub Actions Inactive

linear-code Bot commented Nov 12, 2026

Copy link

Copy Markdown

CODAGT-1460

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot assigned mafredri

Nov 12, 2026

mafredri commented Nov 12, 2026

Copy link

Copy Markdown

Member Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot commented Nov 12, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-12T12:41:54.674791Z	`0e9afa7`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector Bot reviewed

Nov 12, 2026

View reviewed changes

chatgpt-codex-connector Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e9afa783b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

site/src/pages/AgentsPage/components/ChatElements/tools/AskUserQuestionTool.test.tsx

		</QueryClientProvider>,
		);

		expect(screen.queryByText("No description provided.")).toBeNull();

chatgpt-codex-connector Bot Nov 12, 2026

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the visual assertion from the behavior test

This DOM-presence assertion only checks that placeholder copy is not rendered, while the new OptionsWithoutDescriptions story already gives Pixel visual coverage for that state. FE1 requires Vitest behavior tests to assert non-visual outcomes and leaves rendered presence to Storybook screenshots, so retain the callback assertion and remove this redundant assertion.

AGENTS.md reference: site/AGENTS.md:L7-L7

Useful? React with 👍 / 👎.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

This branch was previously deployed

1 inactive deployment

main — 0e9afa78 Deployed Nov 12, 2026 by mafredri via community-label #254890

Reviewers

chatgpt-codex-connector[bot]

chatgpt-codex-connector[bot] left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

mafredri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mafredri commented Nov 12, 2026

Uh oh!

linear-code Bot commented Nov 12, 2026

Uh oh!

mafredri commented Nov 12, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chatgpt-codex-connector Bot commented Nov 12, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.