GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — feat(site/src): add the Coder Agents projects page by jaaydenh · Pull Request #32083 · coder/coder Conversation
Contributor
Adds the Coder Agents Projects page at
The page's Storybook stories and the user docs are in the PR stacked on top, to keep this one under the size limit. Verification
Dogfood ran on a dev deployment with seeded projects, chats in every state, and projects shared by user and group. It took several rounds; the last ones checked mouse and keyboard focus in the Edit and Delete dialogs, stable card controls after an unpin, the pending-pin state, icon contrast, tooltip placement, and a full regression pass, in light and dark themes and at narrow width.
Note Most of this PR was written by AI agents (Xum, with UAT run through Coder Agents). The verification above is from those runs.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Chain the pin rollback, clean drafts on delete at the mutation level, return focus to New project after a delete, show refetch errors above cached cards, and add menu and phone stories. …ng and address UAT findings Unpinning from a card's pin button now moves focus to the card's actions button instead of dropping it to the page. The actions button collapses at rest so the pin icon sits in the card's corner, tab changes push history entries, the load error hides debug details, skeletons match card height, and only the needs-attention icon uses the warning color so the label keeps readable contrast. …eady card controls - Keep focus in the Edit and Delete dialogs opened from a card's menu: the closing menu returned focus to its trigger behind the dialog. - Drop repeat pin and unpin requests for a project while one runs. - Put the actions button before the pin button so the pin stays put when the actions button appears on hover. - Activate tabs manually so a mouse click adds one history entry, not two. …log' into jaayden/projects-page-wt … that a card's menu opens with the mouse …ing pin and keep card controls in place - Track pending pins per project: pins queue in one scope, so a guard on the latest pin let a repeat for an earlier project through. A card hides Pin and shows a spinner while its pin is pending. - Keep the pin's slot after unpinning, so a second click there does not open the actions menu. - Open the unpin tooltip below the button, inside the card. - Use the highlight orange for the needs attention icon, which has enough contrast in the light theme. …eat pin guard, which the card's hidden Pin item covers … stories to a separate branch …and address review findings - Restore the summaries cache when an unpin fails, as the sidebar does. - Narrow pending pin variables with a type guard instead of a cast. - Move the card's corner actions into their own component and flatten the tab body into one panel. - Assert the pin request instead of rendered state in the page test, and keep only the screen-reader member rows in the card's description test. …in forced colors and trim test comments …the menu closes and fix UAT focus issues Edit and Delete now open their dialog from the menu's onCloseAutoFocus, so the closing menu can no longer take focus from the dialog's field. Retry moves focus to New project once the projects load, a fast double-click on Unpin sends one request, the card link shows the full project name as its title, and the Unpin tooltip aligns to the card's edge. …t_count with the other activity fields …the page and the pending pin hold Test the tab ordering and owner split through the rendered page, which also covers the tab wiring and the user ID, so getProjectsByTab no longer needs a test-only export. Restore coverage that each project's pending pin keeps Pin out of its menu.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.