GeezerVison

All reactions

Keep async questions hidden until their web UI answer flow is ready.
The experiment is deployment-scoped and remains outside the safe set.

Let questions return an ID that a later user answer can reference.
Bound async result size so tool-result truncation cannot remove that ID,
and preserve the blocking question contract for plan mode.

Let web UI root chats continue after asking for a user decision when
the hidden experiment is enabled. Send question pushes only after the
tool result commits, without changing plan-mode or API-chat behavior.

Co-authored-by: Michael Suchacz <[email protected]>

…nc tool

Keep blocking question results and tools from other sources out of the
async question push path when a turn does not offer the async tool.

Distinguish blocking questions from async questions even when the tool
name and turn-stop policy match. Preserve the API plan-root coverage
while checking the turn environment flag for every policy case.

Use the shared Fantasy conversion so a text result works in both its
value and pointer forms, as it does elsewhere in the generation path.

Expose the running-turn assertions in the continued-execution scenario
and distinguish the completion push from the question push. Use named
options for each test setup and remove the redundant error assertion.

Keep the comments precise about tool configuration and post-commit
question pushes, and separate body preparation from scheduling.

…estion

Move the async result into its own function so Run shows the async and
blocking branches side by side, and break up the "too long" message.
In the tests, write the JSON inputs as multi-line raw strings and
separate arrange, act and assert in each subtest.

Name the fake model's three behaviors, the tool call input, the state
passed to the held-call callback and the turn result, and move the
committed question_id lookup into a helper, so each subtest reads top
to bottom. The assertions are unchanged.

…n policy

Name the client type and experiment conditions that select the async
tool, document the new tool-policy test fields, and separate the
ask_user_question assertions from the toolset assertions.

mafredri temporarily deployed to main November 12, 2026 13:10 — with GitHub Actions Inactive

mafredri temporarily deployed to main November 12, 2026 13:10 — with GitHub Actions Inactive

Copy link

Copy Markdown