GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — fix(coderd/schedule/cron): share schedule vectors, compare zone names without case by ThomasK33 · Pull Request #32087 · coder/coder Conversation
Member
WhyThe review of #32063 asked how the browser preview of an automation's next runs stays in agreement with the server (review, reply). The reviewer found that Part of CODAGT-1135. What changed
Scope
Tradeoffs
Live checkNone: a library change with no caller yet. Generated with
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
A host with a case-insensitive file system loads "factory" as the file "Factory", so the exact-case checks in Standard let it through. Compare posix, right, Local, localtime, posixrules and Factory with strings.EqualFold, and add table cases for factory, LOCAL, LOCALTIME, POSIX/UTC and Right/UTC. Part of CODAGT-1135. --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-sonnet-5-5` • Thinking: `xhigh`_ testdata/standard_vectors.json lists specs that Standard accepts and rejects, and the runs that Next gives around daylight saving changes. It is the contract for a browser preview of a schedule: a test of the preview can read the same file, so a difference from the server fails CI on one side. The runs replace the rows of TestStandard_Next_DST, which proved the same thing in Go, and add the review's America/New_York `*/15 * * * *` case on 2026-11-01. Part of CODAGT-1135. --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-sonnet-5-5` • Thinking: `xhigh`_ The comment said that Adak, Anchorage, Atka, Metlakatla, Nome and Yakutat changed at 15:33:32 like Juneau. They changed at other times with seconds, and Next walks 1,441 readings in each of them. Part of CODAGT-1135. --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-sonnet-5-5` • Thinking: `xhigh`_ …ason Only the names in the posix, right and file lists need a case-insensitive file system to be a risk. Local is not a file, so the Standard doc no longer gives one reason for all six names. The reason moves to containsFold. Part of CODAGT-1135. --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-sonnet-5-5` • Thinking: `xhigh`_
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
1b8677de
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.