GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WIP: fix Storybook by ShMcK · Pull Request #587 · coderoad/coderoad-vscode

Conversation

@ShMcK

@ShMcK ShMcK commented Mar 23, 2022

Copy link
Copy Markdown
Member

Get Storybook working again.

Signed-off-by: shmck [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShMcK ShMcK mentioned this pull request Mar 23, 2022
Component Testing #201
Open
@SavvyShah

SavvyShah commented Mar 23, 2022

Copy link
Copy Markdown
Contributor

I can help you with this. We can have a talk.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShMcK added 2 commits March 23, 2022 20:49
@ShMcK
get storybook to build again in a webpack 5 world
276b695 
Signed-off-by: shmck <[email protected]>
@ShMcK
migrate storybook to use main.ts
cb54ae5 
Signed-off-by: shmck <[email protected]>
@ShMcK
ShMcK force-pushed the fix/storybook branch from 5a76ea9 to cb54ae5 Compare March 24, 2022 04:23
@ShMcK
setup a single storybook story
4b5123a 
Signed-off-by: shmck <[email protected]>
@ShMcK

ShMcK commented Mar 24, 2022

Copy link
Copy Markdown
Member Author

@SavvyShah I've sent you an email.

There are some remaining issues with the storybook setup:

  1. I have only enabled a single example story. Others can be added in .storybook/main.ts
  2. the addons in storybook 6 have changed (https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#new-addon-presets). with-knobs is deprecated but heavily used in the project
  3. 'babel-plugin-import' which is used to simplify a component library imports doesn't seem to work with webpack anymore (https://www.npmjs.com/package/babel-plugin-import). It's currently disabled.
  4. There are a number of TS errors in the stories.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SavvyShah

SavvyShah commented Mar 24, 2022

Copy link
Copy Markdown
Contributor

Can we use a codemod to convert storiesOf to CSF?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SavvyShah SavvyShah mentioned this pull request Sep 30, 2022
fix: converting stories #599
Open
@SavvyShah

SavvyShah commented Sep 30, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hey @ShMcK . Sorry I have been slow in doing this. But I've made a couple of changes and configured an additional story.
I have linked a PR where I have made changes.
I found that mocking to the global API should be done in preview.ts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShMcK
ShMcK commented Oct 2, 2022
View reviewed changes
Comment thread web-app/.storybook/webpack.config.js
// libraryName: '@alifd/next',
// style: true,
// },
// ])

@ShMcK ShMcK Oct 2, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry some components may not work without @alifd/next and emotion support. But I may be wrong!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SavvyShah SavvyShah Oct 4, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated my branch. I've also enabled the plugin. Seems to be working.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShMcK

ShMcK commented Oct 2, 2022

Copy link
Copy Markdown
Member Author

Thanks @SavvyShah !
There seem to be some yarn.lock conflicts. These can likely be resolved by deleting the yarn.lock file and running yarn again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@SavvyShah SavvyShah SavvyShah left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ShMcK @SavvyShah
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.