GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Phase 3: chat mode + kernel unit tests by codewithfourtix · Pull Request #4 · codewithfourtix/ember

Conversation

@codewithfourtix

@codewithfourtix codewithfourtix commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Polish pass — makes ember usable as an assistant and adds a test suite.

Chat mode

--chat wraps the prompt in Qwen's ChatML template (with --system), streams only the reply, and stops at <|im_end|>. Verified against the NumPy reference:

Q: Write a haiku about Rust programming.
A: Rust's syntax shines, / Type-safe, concise, and fast, / Programming heaven.

Tests

cargo test covers every kernel against small hand-checked values: mat-vec, RMSNorm (unit RMS), RoPE (norm-preserving), SwiGLU, softmax, greedy/RNG sampling, and INT8/INT4 quantization round-trips + memory. Constants cross-checked in NumPy.

Completes the three-phase plan. Remaining: tokens/sec numbers, which need the binary built on a host without the local Smart App Control toolchain block.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
codewithfourtix added 4 commits July 14, 2026 13:04
@codewithfourtix
feat(chat): Qwen ChatML prompt formatting
d84b9fb 
Wraps a user turn (with system prompt) in the template the instruct models are
trained on, so the model answers rather than completes.
@codewithfourtix
feat(cli): --chat and --system flags
c326fbe 
In chat mode the prompt is templated and only the assistant's reply is streamed;
completion mode is unchanged. Generation stops on the <|im_end|> turn token.
@codewithfourtix
test: unit tests for the kernels
c8fd0d6 
Covers mat-vec, RMSNorm (unit RMS), RoPE (norm-preserving), SwiGLU, softmax,
greedy/RNG sampling, and INT8/INT4 quantization round-trips and memory — all
against small hand-checked values.
@codewithfourtix
docs: mark Phase 3 complete; add the chat demo
64a3200
Copilot AI review requested due to automatic review settings July 14, 2026 08:04
@codewithfourtix
codewithfourtix merged commit dbaddd9 into main Jul 14, 2026
Copilot AI reviewed Jul 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codewithfourtix
codewithfourtix deleted the feat/phase-3-chat-and-tests branch July 14, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@codewithfourtix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.