GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: 人工节点选中分支后未提示分支内审批人设定 (#259) by xlorne · Pull Request #262 · codingapi/flow-engine

Conversation

xlorne commented Nov 10, 2026

Copy link

Copy Markdown

Contributor

开始节点提交时只对直接下游节点做 APPROVER_SELECT 判断，人工节点选中分支后
matchNextNodes 返回的是分支节点（MANUAL_BRANCH），分支内的审批人设定节点因而被漏判：前端不弹选人框，流程直接流转到该节点并因无审批人异常（同 #258 根因）。
改为与审批节点提交路径一致，复用 collectApproverSelectNodes 递归收集，
条件分支仍只沿命中分支、分支节点只看首个节点，兼容 #200 / #231 行为。

Closes #259

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix: 人工节点选中分支后未提示分支内审批人设定 (#259)

bd15fe7

开始节点提交时只对直接下游节点做 APPROVER_SELECT 判断，人工节点选中分支后
matchNextNodes 返回的是分支节点（MANUAL_BRANCH），分支内的审批人设定节点因而
被漏判：前端不弹选人框，流程直接流转到该节点并因无审批人异常（同 #258 根因）。
改为与审批节点提交路径一致，复用 collectApproverSelectNodes 递归收集，
条件分支仍只沿命中分支、分支节点只看首个节点，兼容 #200 / #231 行为。

Closes #259

xlorne merged commit 3766d75 into dev

Nov 10, 2026

1 check passed

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Nov 10, 2026

Copy link

Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.45%. Comparing base (046e83c) to head (bd15fe7).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev     #262      +/-   ##
============================================
- Coverage     74.49%   74.45%   -0.05%     
+ Complexity     1808     1806       -2     
============================================
  Files           236      236              
  Lines          7485     7484       -1     
  Branches        865      861       -4     
============================================
- Hits           5576     5572       -4     
- Misses         1487     1490       +3     
  Partials        422      422

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

xlorne deleted the feature/issue-259-manual-branch-approver-select branch

November 12, 2026 02:32

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.