GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(branch): accept GitHub merge queue branches by default by shenxianpeng · Pull Request #653 · commit-check/commit-check

Conversation

@shenxianpeng

@shenxianpeng shenxianpeng commented Nov 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Summary

GitHub's merge queue runs merge_group checks on a branch it creates itself, gh-readonly-queue/<base>/pr-<N>-<sha>, and GITHUB_REF_NAME holds that name. CC201 rejected it. Because the Action's branch input defaults to true, a repository that has a merge queue and makes Commit Check a required check (which GitHub then also requires on merge_group) failed every queue entry.

The name is now accepted next to main, master, develop, HEAD and PR-*. Nobody picks this name, so it passes whatever allow_branch_types or allow_branch_names are set to.

Before vs after

$ git checkout --detach
$ GITHUB_ACTIONS=true GITHUB_REF_NAME=gh-readonly-queue/main/pr-12-0123456789abcdef \
  GITHUB_REF_TYPE=branch commit-check -b --no-banner
Before (2.19.4) After
Output CC201 branch check failed ==> gh-readonly-queue/main/pr-12-0123456789abcdef (nothing)
Exit code 1 0

Changes

  • commit_check/rule_builder.py: adds gh-readonly-queue/.+ to the built-in branch names.
  • README.md: the allow_branch_names row lists it.
  • Tests: the built-in names pattern; the queue branch passes with default config, custom types, and custom names; the bare gh-readonly-queue and a prefixed name are still rejected.

Testing

  • pytest: 1451 pass. The one failure, test_load_config_file_permission_error, happens only because the tests ran as root locally. It is unrelated.
  • Coverage stays at 100% lines and branches, and ruff check / ruff format --check are clean.

Once this ships, the site's rules.md, configuration.md and example.md lines that list the always-accepted names can add it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@shenxianpeng
fix(branch): accept GitHub merge queue branches by default
d8db440
GitHub's merge queue runs merge_group checks on a branch it names
gh-readonly-queue/<base>/pr-<N>-<sha>. CC201 rejected it, so a repository
with a required Commit Check and a merge queue failed every queue entry.
Accept it beside main, master, develop, HEAD and PR-*.
@shenxianpeng
shenxianpeng requested a review from a team as a code owner November 4, 2026 16:44
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d4b4a26c-3dde-4032-abec-b17c8faab942
Commits

Reviewing files that changed from the base of the PR and between 7eec0ac and d8db440.

Files selected for processing: 3
  • README.md
  • commit_check/rule_builder.py
  • tests/rule_builder_test.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shenxianpeng shenxianpeng self-assigned this Nov 4, 2026
@github-actions github-actions Bot added the bug Something isn't working label Nov 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7eec0ac) to head (d8db440).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #653   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         2429      2429           
  Branches       470       470           
=========================================
  Hits          2429      2429           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@codspeed

codspeed Bot commented Nov 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 136 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 653 untouched benchmarks
⏩ 126 skipped benchmarks1


Comparing fix/merge-queue-branch (d8db440) with main (7eec0ac)

Open in CodSpeed

Footnotes

  1. 126 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shenxianpeng
shenxianpeng merged commit 88a0b0b into main Nov 4, 2026
49 of 52 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@shenxianpeng
shenxianpeng deleted the fix/merge-queue-branch branch November 4, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@shenxianpeng shenxianpeng

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@shenxianpeng
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.