GeezerVison is showing github.com — ci: publish to PyPI with Trusted Publishing to get provenance by shenxianpeng · Pull Request #691 · commit-check/commit-check
Conversation
Why
The v2.20.4 release page on PyPI says No provenance. publish.yml already uses pypa/gh-action-pypi-publish, but it uploads with password: ${{ secrets.PYPI_API_TOKEN }}. PyPI only accepts and shows PEP 740 attestations when the upload uses Trusted Publishing (OIDC). With a token the action skips them.
Change
- PyPI step: drop the
password: line, so the action uses the job's existing id-token: write (Trusted Publishing) and uploads attestations by default.
- Job runs in a
pypi environment (url: https://pypi.org/p/commit-check), matching the trusted publisher on PyPI.
- TestPyPI dry run (
workflow_dispatch) is unchanged and still uses TEST_PYPI_TOKEN.
actions/attest-build-provenance stays; it feeds gh attestation verify, which is separate from PyPI's provenance.
Before vs after
|
Before |
After |
| Upload auth |
Long-lived PYPI_API_TOKEN |
Short-lived OIDC token |
| PyPI release page |
No provenance |
Provenance from publish.yml |
/integrity/.../provenance |
404 |
Attestation bundle |
Needed before merging
Add a trusted publisher at https://pypi.org/manage/project/commit-check/settings/publishing/ with owner commit-check, repository commit-check, workflow publish.yml, environment pypi. Without it the next release fails at the upload step. After one good release, delete the PYPI_API_TOKEN secret and revoke the token on PyPI.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
PyPI only stores PEP 740 attestations, and shows provenance, when the
upload uses Trusted Publishing. Drop the PYPI_API_TOKEN password and
run the job in a pypi environment that the trusted publisher names.
Warning
Review limit reached
You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.
Next included review available in 28 minutes.
Check out review usage here.
View limit details
-
Limit details: You’ve used the included review currently available.
Learn how review limits work.
Review configuration:
Run configuration
-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
4fd02d8c-1cdd-4c45-bb2c-eb768dd68dfd
Commits
-
Reviewing files that changed from the base of the PR and between 17f4e06 and b469b40.
Files selected for processing: 1
-
.github/workflows/publish.yml
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Share
-
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.