GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Disable flaky timeouts in test server by smaye81 · Pull Request #651 · connectrpc/connect-es

Conversation

@smaye81

@smaye81 smaye81 commented May 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Node 18 introduced a change which enabled two timeout values on the HTTP server by default.

However, this change seems to be a bit buggy and causes flakiness in our Node test servers in v18 and above. So, this PR disables these by default (which is the behavior of v17 and below).

For other bug reports, see:

  • Every connection gets closed by ERR_HTTP_REQUEST_TIMEOUT after a minute b3nsn0w/koa-easy-ws#36
  • Consider disabling server.requestTimeout and server.headersTimeout by default nodejs/node#44228

Verified by running CI tests 5x with no failures.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Steve Ayers
Disable timeouts
57a8eb8
smaye81
smaye81 commented May 24, 2023
View reviewed changes
Comment thread packages/connect-node/src/node-universal-handler.spec.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@smaye81
smaye81 requested a review from timostamm May 24, 2023 15:23
@smaye81
smaye81 marked this pull request as ready for review May 24, 2023 15:23
@smaye81
smaye81 requested a review from dimitropoulos May 24, 2023 15:23
timostamm
timostamm approved these changes May 24, 2023
View reviewed changes

@timostamm timostamm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@smaye81
smaye81 merged commit 9c998ae into main May 24, 2023
@smaye81
smaye81 deleted the sayers/fix_flaky_test branch May 24, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timostamm timostamm timostamm approved these changes
@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@smaye81 @timostamm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.