GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test(restart): drop outdated containerd 1.x plugin requirement from restart tests by webdevsamran · Pull Request #5185 · containerd/nerdctl

Conversation

@webdevsamran

@webdevsamran webdevsamran commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Description

Drops the outdated containerd 1.x nerdtest.ContainerdPlugin("io.containerd.internal.v1", "restart", ...) requirement check from the restart-policy integration tests in cmd/nerdctl/container/container_run_restart_linux_test.go.

In containerd 2.x, the restart monitor is no longer registered under io.containerd.internal.v1, causing these tests to silently skip during test runs.

As discussed and approved in #5175 by @AkihiroSuda, dropping this stale gate enables the restart-policy tests to run on containerd 2.x.

Fixes #5175

AI coding assistance was used for initial investigation; changes were manually reviewed and compilation-tested.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@webdevsamran
test(restart): drop outdated containerd 1.x plugin requirement from r…
f99df63 
…estart tests

Signed-off-by: Samran Asif <[email protected]>
@AkihiroSuda AkihiroSuda added this to the v2.4.0 milestone Sep 8, 2026
AkihiroSuda
AkihiroSuda approved these changes Sep 8, 2026
View reviewed changes

@AkihiroSuda AkihiroSuda left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AkihiroSuda
AkihiroSuda merged commit 61dba3d into containerd:main Sep 8, 2026
47 of 50 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.4.0

Development

Successfully merging this pull request may close these issues.

Restart-policy tests silently skip on containerd 2.x

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@webdevsamran @AkihiroSuda
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.