GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(header): read description delimiter exactly as ": " by gumbo2k · Pull Request #1 · conventionalcommit/parser

Conversation

@gumbo2k

@gumbo2k gumbo2k commented Jul 15, 2024

Copy link
Copy Markdown
Contributor

This fixes an issue where a commit header like
this: type(scope): :bulb: look a light bulb! will case an error. lexer.Take() is greedy and will read : : into the Current() token and thus will fail the comparison to the expected delimiter (: ).

fixes: conventionalcommit/commitlint#15

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gumbo2k
fix(header): Read description delimiter exactly as ": "
3743014 
This fixes an issue where a commit header like
this: `type(scope): 💡 look a light bulb!` will case
an error. `lexer.Take()` is greedy and will read `: :`
into the `Current()` token and thus will fail the comparison
to the expected delimiter (`: `).
@muthukrishnan24 muthukrishnan24 changed the title fix(header): Read description delimiter exactly as ": " fix(header): read description delimiter exactly as ": " Mar 15, 2025
@muthukrishnan24
muthukrishnan24 self-requested a review March 15, 2025 13:53
muthukrishnan24
muthukrishnan24 approved these changes Mar 15, 2025
View reviewed changes
@muthukrishnan24
muthukrishnan24 self-requested a review March 15, 2025 14:05
@muthukrishnan24
muthukrishnan24 merged commit a8ffa3a into conventionalcommit:master Mar 15, 2025
@muthukrishnan24

muthukrishnan24 commented Mar 15, 2025

Copy link
Copy Markdown
Contributor

Sorry for the delay.

Thanks for your contribution!

LGTM, merging now.
gumbo2k reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muthukrishnan24 muthukrishnan24 Awaiting requested review from muthukrishnan24

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow gitmojis

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gumbo2k @muthukrishnan24
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.