Description

amerry

opened on Apr 15, 2016

Issue body actions

If I do something like

#include <boost/asio/ip/address.hpp>
#include <boost/network.hpp>

then compilation fails because the references to things like asio::io_service in cpp-netlib resolve to the boost::asio namespace (since the code is in the boost::network namespace).

While I can just reorder the headers, this is still not an ideal situation. Presumably, this could be solved by using absolute references, like ::asio::io_service.

Activity

1. glynos

   self-assigned this

   on Apr 15, 2016
2. deanberris commented on Apr 18, 2016

   

   deanberris

   on Apr 18, 2016

   Member

   More actions

   Yes, this is bad. I see @glynos has taken this on.

   Do you mind fixing this in the 0.12-release branch too so that we can release a 0.12.1 soon to remedy this?
3. glynos commented on Apr 20, 2016

   

   glynos

   on Apr 20, 2016

   Member

   More actions

   @amerry Could you check that the latest changes work for you?
4. amerry commented on Apr 26, 2016

   

   amerry

   on Apr 26, 2016

   Author

   More actions

   Yep, 0.12-release now works.
5. avalchev commented on Apr 29, 2016

   

   avalchev

   on Apr 29, 2016

   More actions

   Could you please merge it into master.
6. glynos commented on Apr 29, 2016

   

   glynos

   on Apr 29, 2016

   Member

   More actions

   @avalchev These changes were already committed on master in a separate PR:

   f2095b6
7. glynos

   closed this as completedon Apr 29, 2016

Issue actions