GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix #677: Exception in async_server_base/async_connection during port scanning (nmap) by vovams · Pull Request #678 · cpp-netlib/cpp-netlib

Conversation

@vovams

@vovams vovams commented Aug 10, 2016

Copy link
Copy Markdown

Fix for issue #677.

During a port scan async_server_base::handle_accept() may be called while the connection is not properly established. No error code is passed to handel_accept() (i.e. !!ec == false) but the subsequent call to async_connection::start() -> stream_handler::remote_endpoint() -> asio::basic_socket::remote_endpoint() fails with an exception.

My fix is to add error checking by using asio::basic_socket::remote_endpoint(asio::error_code&) overload in stream_handler::remote_endpoint() and passing the error to async_connection::start().

Since i had to change signature of stream_handler::remote_endpoint(), i added a new overload with old signature and behavior to keep any code which uses it working.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vovams
Fixed possible exception in async_connection under port scanning (cpp…
86529f2 
…-netlib#677)
@vovams vovams mentioned this pull request Aug 10, 2016
Exception in async_server_base/async_connection during port scanning (nmap) #677
Open
@glynos

glynos commented Aug 10, 2016

Copy link
Copy Markdown
Member

@vovams sorry, the 0.12-release branch is not correct. Please apply the PR to the 0.13-release branch. The PR looks good, though.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@glynos glynos closed this Aug 10, 2016
@vovams

vovams commented Aug 11, 2016

Copy link
Copy Markdown
Author

I can adapt the fix for 0.13, but what about 0.12? I wanted to merge the fix into it because i am using 0.12 in my project.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris

deanberris commented Aug 11, 2016

Copy link
Copy Markdown
Member

@glynos -- Do you think it's OK for us to pull this in then release a 0.12.1 to address just this issue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@glynos

glynos commented Aug 11, 2016

Copy link
Copy Markdown
Member

@deanberris -- No, we agreed that some changes in 0.12 were mistakenly added, and reverted those changes in 0.13. We are slow to release a 0.13 version, but I think this should be a part of it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris

deanberris commented Aug 11, 2016

Copy link
Copy Markdown
Member

Okay, SGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vovams vovams mentioned this pull request Aug 11, 2016
Fix #677 in 0.13: Exception in async_server_base/async_connection during port scanning (nmap) #679
Merged
@vovams

vovams commented Aug 11, 2016

Copy link
Copy Markdown
Author

I do not know your release plans, but branch 0.12-release currently contains some other fixes as well. For example, 79aaa62, because of which i had to switch my project from cpp-netlib-0.12.0-final tag to the tip of 0.12-release. So a bugfix release might be useful.

Anyway, i opened new pull request for 0.13-release: #679.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vovams @glynos @deanberris
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.