GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — replace std::shared_future with boost::shared_future by dvd0101 · Pull Request #684 · cpp-netlib/cpp-netlib

Conversation

@dvd0101

@dvd0101 dvd0101 commented Sep 18, 2016

Copy link
Copy Markdown

This PR replaces std::promise and std::shared_future with boost equivalents.

This change fixes the compilation errors when the ready() wrapper is used.

I've added a test and a few words of documentation.

This should address #683 and #592

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
dvd0101 added 3 commits September 19, 2016 00:08
@dvd0101
new test to cover the ready() wrapper
d5df753
it does not compile now
@dvd0101
replace std::promise/std::shared_future with boost equivalents
ecdae1e
boost::shared_future has a richer api, notably it has the `is_ready()`
method required by the `ready()` wrapper
@dvd0101
docs
db13ac3
@deanberris deanberris assigned glynos Sep 19, 2016
@deanberris

deanberris commented Sep 19, 2016

Copy link
Copy Markdown
Member

@cinghiale -- looks like the tests have failed, can you please have a look to see why?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dvd0101

dvd0101 commented Sep 19, 2016

Copy link
Copy Markdown
Author

@deanberris it looks like a timeout of the install_boost script, I don't think it is related. How can I trigger a rebuild? Are you ok with an empty commit?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dvd0101
trigger travis
9835d24
@dvd0101

dvd0101 commented Sep 19, 2016

Copy link
Copy Markdown
Author

The test timeout during the boost installation; any idea?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@deanberris

deanberris commented Sep 20, 2016

Copy link
Copy Markdown
Member

I remember this being an issue back then -- I'm not sure exactly how I resolved this, but it's a limitation of the Travis runners. So this might not be something you @cinghiale can fix. 😦

I'll defer to @glynos on whether to merge this with minimal testing. But I'm certainly fine with something that, if it works for you, is good enough to merge.

There's probably a more updated way of installing a more recent Boost installation now without having to rebuild it every time (and relying on the cache) but I've not time to have a look.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@glynos
glynos merged commit 9835d24 into cpp-netlib:0.13-release Sep 24, 2016
@glynos

glynos commented Sep 24, 2016

Copy link
Copy Markdown
Member

I merged it into 0.13-release, but I haven't fixed the failures on clang on Travis. I'll be away for a few days and take another look later next week.

Thanks for your contribution, @cinghiale!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dvd0101

dvd0101 commented Oct 9, 2016

Copy link
Copy Markdown
Author

I notice that this PR has not yet been merged on master.

If you want I can take care of the fixes needed to apply it on the master and then proceed with a new PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@deanberris

deanberris commented Oct 10, 2016

Copy link
Copy Markdown
Member

@cinghiale -- I think @glynos and I would prefer seeing another PR just for the master branch. Since we don't merge back changes manually to master, and since this may not apply cleanly even then.

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dvd0101 dvd0101 mentioned this pull request Oct 15, 2016
Boost future master #698
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@glynos glynos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@dvd0101 @deanberris @glynos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.