GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add client size close for 0.13-release by chenzhaoyu · Pull Request #719 · cpp-netlib/cpp-netlib

Conversation

@chenzhaoyu

@chenzhaoyu chenzhaoyu commented Dec 14, 2016

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chenzhaoyu
add client size close
bcdca47
anonimal
anonimal reviewed Dec 14, 2016
View reviewed changes
Comment thread boost/network/protocol/http/client/connection/async_protocol_handler.hpp Outdated
headers.insert(header_pair);
if (boost::iequals(header_pair.first, "Content-Length")) {
is_content_length = true;
content_length = std::stoi(header_pair.second);

@anonimal anonimal Dec 14, 2016

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::stoi(maliciously large amount)

And what if std::out_of_range is thrown? Would this be caught earlier/later?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@chenzhaoyu chenzhaoyu Dec 15, 2016

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any Content-Length greater than or equal to zero is a valid value.If Content-Length is larger than long long , I will ignore to handle it.Please check again,thanks~

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chenzhaoyu
fix content_length parse error
0e91891
deanberris
deanberris approved these changes Dec 15, 2016
View reviewed changes

@deanberris deanberris left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @chenzhaoyu and @anonimal for the review!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@deanberris
deanberris merged commit 1277fa6 into cpp-netlib:0.13-release Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deanberris deanberris deanberris approved these changes
+1 more reviewer
@anonimal anonimal anonimal left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@chenzhaoyu @deanberris @anonimal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.