GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Build: allow options to use Boost + OpenSSL static libs by anonimal · Pull Request #722 · cpp-netlib/cpp-netlib

Conversation

@anonimal

@anonimal anonimal commented Jan 8, 2017

Copy link
Copy Markdown

Though usually not encouraged, there are use-cases for linking openssl statically (windows without openssl installed, static apps, etc.) and, though it's not as much of a security issue, the same use-cases apply to boost (so static apps don't end up linking boost dynamically because of cpp-netlib).

Default is OFF for both options (as I think it should be since those who need it will know when to use it).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anonimal
Build: allow options to use Boost + OpenSSL static libs
80b46bd
@deanberris

deanberris commented Jan 9, 2017

Copy link
Copy Markdown
Member

LGTM -- ideally though we really ought to just remove the dependency on Boost if we can really achieve that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris
deanberris merged commit 92d41b7 into cpp-netlib:0.13-release Jan 9, 2017
@deanberris

deanberris commented Jan 9, 2017

Copy link
Copy Markdown
Member

@anonimal -- do you mind sending this change up to master as well?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonimal

anonimal commented Jan 9, 2017

Copy link
Copy Markdown
Author

@deanberris sure, no problem. By the way, I'm currently dealing with this cmake issue. It may or may not be related to cpp-netlib, I'll keep you posted if it ends up being an implementation issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonimal anonimal mentioned this pull request Jan 9, 2017
Build: allow options to use Boost + OpenSSL static libs #724
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@anonimal @deanberris
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.