GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Build: fix GCC 7 implicit fallthrough warnings by anonimal · Pull Request #769 · cpp-netlib/cpp-netlib

Conversation

@anonimal

@anonimal anonimal commented Jul 19, 2017

Copy link
Copy Markdown

From https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html:

C++17 provides a standard way to suppress the -Wimplicit-fallthrough
warning using [[fallthrough]]; instead of the GNU attribute. In C++11 or
C++14 users can use [[gnu::fallthrough]];, which is a GNU extension.
Instead of these attributes, it is also possible to add a fallthrough
comment to silence the warning.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anonimal
Build: fix GCC 7 implicit fallthrough warnings
ab56ec4 
From https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html:

>C++17 provides a standard way to suppress the -Wimplicit-fallthrough
warning using [[fallthrough]]; instead of the GNU attribute. In C++11 or
C++14 users can use [[gnu::fallthrough]];, which is a GNU extension.
Instead of these attributes, it is also possible to add a fallthrough
comment to silence the warning.
@anonimal

anonimal commented Aug 29, 2017

Copy link
Copy Markdown
Author

@deanberris @glynos ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris
deanberris self-requested a review October 17, 2017 13:57
@deanberris deanberris self-assigned this Oct 17, 2017
@deanberris

deanberris commented Oct 17, 2017

Copy link
Copy Markdown
Member

LGTM -- I'm wondering though whether GCC doesn't have an attribute for this instead, like Clang does?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris
deanberris merged commit 7ab74c5 into cpp-netlib:0.13-release Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deanberris deanberris Awaiting requested review from deanberris

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@deanberris deanberris

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@anonimal @deanberris
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.