GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Do not wrap exceptions passed to boost::promise::set_exception in std… by HighCommander4 · Pull Request #819 · cpp-netlib/cpp-netlib

Conversation

@HighCommander4

@HighCommander4 HighCommander4 commented Feb 14, 2018

Copy link
Copy Markdown

…::exception_ptr (fixes #815)

boost::promise only knows about boost::exception_ptr, and handles
wrapping of concrete exception types into that itself. If passed
std::exception_ptr, it will wrap it a second time and later throw
the std::exception_ptr itself.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@HighCommander4
Do not wrap exceptions passed to boost::promise::set_exception in std…
5701041 
…::exception_ptr (fixes cpp-netlib#815)

boost::promise only knows about boost::exception_ptr, and handles
wrapping of concrete exception types into that itself. If passed
std::exception_ptr, it will wrap it a second time and later throw
the std::exception_ptr itself.
deanberris
deanberris approved these changes Feb 14, 2018
View reviewed changes

@deanberris deanberris left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @HighCommander4!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@deanberris
deanberris merged commit 73d4024 into cpp-netlib:0.13-release Feb 14, 2018
@coneiric coneiric mentioned this pull request May 20, 2018
HTTP: don't catch / rethrow std::exception_ptr monero-project/kovri#872
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deanberris deanberris deanberris approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@HighCommander4 @deanberris
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.