GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — added environment variable `UNUSEDFUNCTION_ONLY` to make sure only the `unusedFunction` check is being executed by firewave · Pull Request #4362 · cppcheck-opensource/cppcheck

Conversation

@firewave

@firewave firewave commented Aug 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

This is to avoid unnecessary checks being performed as well as speeding up things. See https://trac.cppcheck.net/ticket/10648 and https://trac.cppcheck.net/ticket/10727.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@firewave firewave changed the title added UNUSEDFUNCTION_ONLY hack to only perform the unusedFunction check added UNUSEDFUNCTION_ONLY hack to only perform the unusedFunction check Aug 16, 2022
@firewave
firewave force-pushed the unused-selfcheck branch from dd66980 to da6273e Compare August 16, 2022 08:30
@firewave
firewave marked this pull request as ready for review August 16, 2022 08:50
@firewave
firewave force-pushed the unused-selfcheck branch from da6273e to 28c4139 Compare August 16, 2022 08:50
@firewave firewave changed the title added UNUSEDFUNCTION_ONLY hack to only perform the unusedFunction check added environment variable UNUSEDFUNCTION_ONLY to make sure only the unusedFunction check is being executed Aug 17, 2022
@danmar

danmar commented Aug 20, 2022

Copy link
Copy Markdown
Collaborator

This seems to be a quick and small hack of the interface. I don't want small hacks in the interface. A bigger picture is wanted. There should be a consistent way to enable/disable all checks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danmar danmar closed this Aug 20, 2022
@firewave

firewave commented Aug 20, 2022

Copy link
Copy Markdown
Collaborator Author

This seems to be a quick and small hack of the interface. I don't want small hacks in the interface. A bigger picture is wanted. There should be a consistent way to enable/disable all checks.

This is just temporary and I have an approach to fix this more appropriately. The ground work and approach is easily implemented. But to get it completely fixed will involve a lot of work and will take quite a while.

It's also not an "interface" and is not documented at all.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danmar danmar reopened this Aug 20, 2022
@danmar

danmar commented Aug 20, 2022

Copy link
Copy Markdown
Collaborator

This is just temporary and I have an approach to fix this more appropriately.

ok.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@firewave

firewave commented Sep 23, 2022

Copy link
Copy Markdown
Collaborator Author

This is to also speed up the callgrind test proposed in #2944.

I will elaborate on steps to get rid of this hack soon.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@firewave

firewave commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator Author

This is to also speed up the callgrind test proposed in #2944.

This reduces Ir from 86,847,240,267 to 82,239,299,916 in the proposed step.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@firewave
firewave marked this pull request as draft September 27, 2022 10:47
@firewave

firewave commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator Author

Not calling the unnecessary Check::getFileInfo() additional reduces it from 80,867,576,736 to 80,458,208,346 (these number are different from the one above since other optimizations applied - the diff is still the same)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@firewave
firewave force-pushed the unused-selfcheck branch from 28c4139 to 30dfd56 Compare September 27, 2022 11:38
@firewave
firewave marked this pull request as ready for review September 27, 2022 11:38
@firewave firewave mentioned this pull request Oct 4, 2022
added (optional) lazy execution of ValueFlow #4521
Draft
firewave added 2 commits October 5, 2022 22:16
@firewave
cppcheck.cpp: added UNUSEDFUNCTION_ONLY hack to only perform the `u…
3a7e580
…nusedFunction` check
@firewave
selfcheck.yml: enabled UNUSEDFUNCTION_ONLY hack
a3ee16c
@firewave
firewave force-pushed the unused-selfcheck branch from 30dfd56 to a3ee16c Compare October 5, 2022 20:18
@danmar
danmar merged commit 9f7a725 into cppcheck-opensource:main Oct 6, 2022
@firewave
firewave deleted the unused-selfcheck branch October 6, 2022 19:08
@firewave firewave mentioned this pull request Oct 7, 2022
selfcheck.yml: re-enable core checks in callgrind step #4538
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@firewave @danmar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.