GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — testrunner: refactored `givenACodeSampleToTokenize` into `SimpleTokenizer` and `SimpleTokenList` / several related cleanups by firewave · Pull Request #6084 · cppcheck-opensource/cppcheck

Conversation

@firewave

@firewave firewave commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@firewave
firewave marked this pull request as draft March 5, 2024 11:18
@firewave

firewave commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator Author

I didn't realize I already did this in #5299 - so adding some more changes from that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@firewave

firewave commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator Author

This will also conflict with #6049.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@firewave firewave changed the title testrunner: refactored givenACodeSampleToTokenize into SimpleTokenizer and SimpleTokenList testrunner: refactored givenACodeSampleToTokenize into SimpleTokenizer and SimpleTokenList / several related cleanups Mar 5, 2024
@firewave
firewave marked this pull request as ready for review March 5, 2024 15:04
@firewave

firewave commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator Author

This should be integrated into the fixture and also not use a wrapper so we can replace even more redundant code but I haven't figured that out yet.
This is done mainly so I can (hopefully) finally land #5299.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@firewave
firewave force-pushed the test-tok-2 branch from 4b68aff to 3d68959 Compare March 6, 2024 13:17
firewave added 7 commits March 8, 2024 13:32
@firewave
testrunner: refactored givenACodeSampleToTokenize into `SimpleToken…
e25d126 
…izer` and `SimpleTokenList`
@firewave
testrunner: pass ErrorLogger into SimpleTokenizer
25a6859
@firewave
testrunner: renamed SimpleTokenList members
cc9b7a7
@firewave
testrunner: more usage of Simple* helpers
b9e616b
@firewave
testrunner: made Simple* objects const if possible
6c37b31
@firewave
testrunner: pass Standards::Language to SimpleTokenList
202ae05
@firewave
testrunner: added missing TokenList::createTokens() checks
24cb9cd
@firewave
firewave force-pushed the test-tok-2 branch from 3d68959 to 24cb9cd Compare March 8, 2024 12:33
danmar
danmar approved these changes Mar 10, 2024
View reviewed changes
@firewave
firewave merged commit fadc93f into cppcheck-opensource:main Mar 10, 2024
@firewave
firewave deleted the test-tok-2 branch March 10, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmar danmar danmar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@firewave @danmar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.