GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — enabled and fixed `modernize-pass-by-value` clang-tidy warnings / avoid some unnecessary copies by firewave · Pull Request #529 · cppcheck-opensource/simplecpp

Conversation

@firewave

@firewave firewave commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
firewave added 2 commits September 1, 2025 07:47
@firewave
enabled and fixed modernize-pass-by-value clang-tidy warnings
2f9fbfd
@firewave
avoid some unnecessary copies
c7311b0
@firewave
firewave marked this pull request as draft September 1, 2025 06:43
@firewave

firewave commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator Author

callgrind in CI

g++ - 74,990,727 -> 76,190,727
clang++ - 70,436,671 -> 71,500,835
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@firewave

firewave commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator Author

Trying to mitigate the regression makes things worse although I am able to reduce the amount of std::string copies. There is still memcpy() calls I do not even understand where they are coming from.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@firewave
attempt to mitigate performance regression
5f396ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@firewave
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.