GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — cleaned up `simplecpp::Macro` construction and assignment by firewave · Pull Request #596 · cppcheck-opensource/simplecpp

Conversation

@firewave

@firewave firewave commented Dec 4, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@firewave firewave changed the title cleanups related to simplecpp::Macro construction and assignment cleaned up simplecpp::Macro construction and assignment Dec 4, 2025
@firewave
firewave force-pushed the macro-emplace branch 3 times, most recently from a431e1f to e3792a3 Compare December 7, 2025 23:37
chrchr-github
chrchr-github reviewed Dec 9, 2025
View reviewed changes
Comment thread simplecpp.cpp Outdated
sizeOfType.insert(std::make_pair("float *", sizeof(float *)));
sizeOfType.insert(std::make_pair("double *", sizeof(double *)));
sizeOfType.insert(std::make_pair("long double *", sizeof(long double *)));
sizeOfType.emplace("char", sizeof(char));

@chrchr-github chrchr-github Dec 9, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block could be an init list, followed by sizeOfType.insert(rawtokens.sizeOfType.begin(), rawtokens.sizeOfType.end()).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@firewave firewave Dec 29, 2025

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not even macro code. I will pull this out in a separate PR and apply you suggestion.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chrchr-github reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@firewave
firewave force-pushed the macro-emplace branch from e3792a3 to 9af5e3e Compare December 29, 2025 21:33
@firewave firewave mentioned this pull request Jan 12, 2026
fixed #616 - report bad macro syntax via OutputList #617
Merged
@firewave
firewave force-pushed the macro-emplace branch 2 times, most recently from aff926a to acf532e Compare February 10, 2026 20:35
firewave added 5 commits February 10, 2026 21:36
@firewave
avoid temporary object creations with macro insertions in `simplecpp:…
9d77056 
…:preprocess()`
@firewave
create Macro objects in-place
383e968
@firewave
changed simplecpp::Macro::tokenListDefine to a shared pointer
c3479ab
@firewave
avoid redundant initialization of simplecpp::Macro::nameTokDef
82eff4f
@firewave
avoid duplicated assignment of simplecpp::Macro::tokenListDefine
492fe29
@firewave
firewave force-pushed the macro-emplace branch from acf532e to e59c999 Compare February 10, 2026 20:36
@firewave
removed unnecessary creation of simplecpp::Macro::tokenListDefine
90037ae
@firewave
firewave force-pushed the macro-emplace branch from e59c999 to 90037ae Compare February 10, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@chrchr-github chrchr-github chrchr-github left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@firewave @chrchr-github
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.