GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix #613: support binary literals in preprocessor checks by ludviggunne · Pull Request #628 · cppcheck-opensource/simplecpp

Conversation

@ludviggunne

@ludviggunne ludviggunne commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ludviggunne
ludviggunne force-pushed the 613 branch from aa18ef5 to 4aac949 Compare February 24, 2026 11:01
@firewave

firewave commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

Please rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@firewave

firewave commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Please rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@firewave firewave linked an issue Jun 2, 2026 that may be closed by this pull request
support binary literals in preprocessor checks #613
Open
@firewave
firewave force-pushed the 613 branch from 4aac949 to d66c70b Compare June 22, 2026 11:10
@firewave

firewave commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

I rebased it, adjusted the expected test result and fixed a clang-tidy warning but it still needs more work...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@firewave
firewave marked this pull request as draft June 22, 2026 11:16
ludviggunne and others added 5 commits July 9, 2026 10:30
@ludviggunne
Add tests
0618d9e
@ludviggunne
Fix cppcheck-opensource#613
bda56f5
@firewave @ludviggunne
run-tests.py: removed fixed expr_usual_conversions.c from exclusion…
01bd386 
… list
@firewave @ludviggunne
simplecpp.cpp: fixed readability-container-size-empty clang-tidy wa…
f54a1b5 
…rning
@ludviggunne
update selfcheck.sh shebang
5855c28
@ludviggunne
ludviggunne force-pushed the 613 branch from a5cc79f to 1f0fe3e Compare July 10, 2026 09:47
firewave
firewave reviewed Jul 10, 2026
View reviewed changes
Comment thread simplecpp.cpp Outdated
d = 10 + c - 'A';
} else {
throw std::runtime_error("invalid integer literal");
// TODO: handle suffix

@firewave firewave Jul 10, 2026

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a ticket if do not plan to address this in this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ludviggunne ludviggunne Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a pretty big change is needed to handle integer conversions/overflow correctly (such as in expr_usual_conversions.c). So I could either keep that file excluded for this PR or tackle the bigger issue before this. Either way I'll create an issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ludviggunne ludviggunne Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#675

I couldn't find a way to add a label, maybe I don't have permissions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ludviggunne added 2 commits July 10, 2026 12:09
@ludviggunne
skip suffix
3acf836
@ludviggunne
update tests
5fb6ef4
@ludviggunne
ludviggunne force-pushed the 613 branch from 1f0fe3e to 5fb6ef4 Compare July 10, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@firewave firewave firewave left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support binary literals in preprocessor checks

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ludviggunne @firewave
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.