GeezerVison

I would prefer us grouping testcases by error category, but this is better than before so I'll approve this after a few minor changes.

Rechecked at b4371d2.

The narrowed change matches the review direction: failures is unique files with findings, changelog wording updated, and num_errors left as the raw error-message count. With only lint findings, tests/failures now match the emitted <testcase> count (e.g. 3 findings in 2 files → failures=2, tests=2, two testcases). Unit test testJUnitXML passes; full suite 206 passed.

LGTM.

Reviewed at b4371d2.

This fixes #431's reported mismatch: lint findings are serialized as one failing testcase per file, and failures plus tests now use that same grouping. The unchanged process-error path is outside #431's lint-finding scope.

Verified locally:

python -m pytest -q --no-cov
231 passed

git diff --check b4371d2^..b4371d2
Passed

LGTM.

Reviewed current head b4371d2 against #431.

For the reported lint-finding path, FormatJUnitXML() emits one testcase/failure per affected file, and the unique-filename count makes both failures and tests match that emitted structure. The sample and unit expectation now reflect the same grouping.

This resolves the reported 123-findings / 2-files mismatch. LGTM.

Reviewed at b4371d21885b2dc2e4d6e07ca3fbcff8eb718ed6.

I reproduced #431 and verified the grouping behavior independently. Multiple lint findings for the same file are emitted as one failing <testcase>, so counting distinct filenames makes the suite-level failures and tests attributes match the generated testcase structure. The 3-findings/2-files case produces failures="2" tests="2", and the silly JUnit sample correctly reduces the 123 findings across 2 files to 2 failing testcases.

I also checked repeated/non-contiguous findings, mixed error/failure output, and the empty-success case. I found no regression introduced by this change.

Validation:

• testJUnitXML: passed
• silly-junit CLI sample: passed
• full pytest: 231 passed
• pylint: passed
• mypy: passed
• pre-commit: passed
• git diff --check: passed

LGTM.