GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CM-72834 show detection shas by Ilanlido · Pull Request #548 · cycodehq/cycode-cli

Conversation

@Ilanlido

@Ilanlido Ilanlido commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

A blocked developer only saw severity counts, so a false positive was unactionable: nothing in the message identified which value tripped the guardrail. List each distinct finding's type and value hash instead, which is what cycode ignore --by-sha takes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Ilanlido and others added 2 commits September 16, 2026 15:11
@Ilanlido @claude
CM-72834: Show the value hash of every guardrail finding
da20eba
A blocked developer only saw severity counts, so a false positive was
unactionable: nothing in the message identified which value tripped the
guardrail. List each distinct finding's type and value hash instead, which
is what `cycode ignore --by-sha` takes.

The hash is safe to display; the value is not. Detections already dropped by
an ignore rule are filtered out upstream in create_local_scan_result, so only
what actually blocked is listed. The two hook messages that interpolated the
summary mid-sentence now put it last, since it spans multiple lines.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
@Ilanlido @claude
CM-72834: Move the violation summary into the guardrails package
5a05f52
build_violation_summary sat in the shared utils/scan_utils.py but has only
ever had one caller, and it is now shaped for a hook message rather than a
terminal - multi-line, with a value hash per finding. Other scan commands
render through the printers, which already have their own Secret SHA column.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
@Ilanlido
Ilanlido requested review from avishaiamiel and omer-roth as code owners September 16, 2026 12:18
@Ilanlido
Ilanlido enabled auto-merge (squash) September 16, 2026 12:18
omer-roth
omer-roth approved these changes Sep 16, 2026
View reviewed changes
@Ilanlido
Ilanlido merged commit f18db6b into main Sep 16, 2026
28 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@Ilanlido
Ilanlido deleted the CM-72834-show-detection-shas branch September 16, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omer-roth omer-roth omer-roth approved these changes
@avishaiamiel avishaiamiel Awaiting requested review from avishaiamiel avishaiamiel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Ilanlido @omer-roth
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.