GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove unnecessary string intern by sergeevik · Pull Request #136 · dashjoin/jsonata-java

Conversation

@sergeevik

@sergeevik sergeevik commented Nov 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

substr / leftPad / rightPad. Performed String.intern() on each input string. This is a slow lookup in the JVM's global string table, which also clutters it with strings from user data, and the result is used only for calculating code points.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sergeevik
remove unnecessary string intern
95ecea8
@aeberhart

aeberhart commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Thanks, looks good. The interned strings are only used for code point counting, so nothing depends on identity.

Note for future changes to substr / leftPad / rightPad: this code originally comes from Jsonata4Java, which is likely no longer maintained, so we have to clean it up here. If we touch these functions again, the following should be addressed as well:

  • Objects.requireNonNull(...) is now redundant: str and padStr are already null-checked in the pad functions, and substr calls str.length() before it.
  • The padding in leftPad / rightPad is built with String += in a loop, which is quadratic in the pad length. StringBuilder or String.repeat would be better.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sergeevik @aeberhart
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.