GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — perf: avoid flattening and shifting result batches by vuanhphung · Pull Request #577 · databricks/databricks-sql-nodejs Conversation
|
| Query | Elapsed, main → PR | Drain, main → PR |
|---|---|---|
| Boolean, 80M rows | 3.602 → 2.625 s | 2.527 → 1.457 s |
| Float, 50M rows | 4.724 → 4.149 s | 1.632 → 1.001 s |
| Double, 30M rows | 4.724 → 4.004 s | 1.068 → 0.651 s |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Vu Anh Phung <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ No issues identified by the review bot.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Vu Anh Phung <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ No issues identified by the review bot.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Vu Anh Phung <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Verdict: 1 Nit
Looks good, no blocking issues. I compared the new offset-based ResultSlicer with the old splice/flat logic for leftovers, exact fits, fractional limits, NaN, zero and negative limits, undefined limits, unbuffered mode and the concatChunks growth past 2**25, and the results match. One benign difference: concatChunks now keeps holes as undefined where flat() dropped them; no current source produces sparse chunks.
(#471)), so this one should end with (#577).
Sorry, something went wrong.
There was an error while loading. Please reload this page.
90843705
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.