GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(telemetry): sanitize error telemetry and report result delivery shape by vuanhphung · Pull Request #596 · databricks/databricks-sql-nodejs Conversation
Collaborator
Error telemetry copied the raw server error message and the JS stack into the emitted Error telemetry now carries only the error class name and the server SQLSTATE. This matches the kernel's sanitized Verification: new unit tests cover the emitted and exported payloads. On origin/main, 15 new or updated tests fail; on this branch the full unit suite passes (1545), and lint, type-check and build are clean. Live Thrift run against a warehouse, with the exporter stubbed to a local capture so nothing was sent:
origin/main on the same run left the delivery fields unset and exported Performance: the change only runs once per statement at close, and once per error, when telemetry is on. In a micro-benchmark (5 alternating fresh-process runs, median), Not addressed here: the Addresses #508 This pull request and its description were written by Isaac.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…hape Error telemetry copied the raw server error message and JS stack into the emitted event and the exported payload, leaking SQL-derived identifiers. It now carries only the error class name and the server SQLSTATE, matching the kernel's sanitized error_info; the emitter, aggregator and exporter each drop message/stack. statement.complete on the Thrift backend now reports resultFormat and compressed from result metadata the backend already holds (direct results or the result path's fetch), with no extra RPC. Signed-off-by: Vu Anh Phung <[email protected]> Co-authored-by: Isaac <[email protected]>
vuanhphung
temporarily deployed
to
azure-prod
vuanhphung
temporarily deployed
to
azure-prod
vuanhphung
temporarily deployed
to
azure-prod
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✅ No issues identified by the review bot.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThis branch was previously deployed1 inactive deployment
azure-prod
—
18cff9e4
Deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |