GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — Cache kernel Session compatibility signature by aakash-saravanan-db · Pull Request #1024 · databricks/databricks-sql-python Conversation
Collaborator
What type of PR is this?
DescriptionCache the native Initialize the cache under a lock and refresh it when the How is this tested?
Added coverage for signature reuse, concurrent initialization, class replacement, Local validation: the full unit suite, separate real-kernel loopback tests, mypy, and Black.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
aakash-saravanan-db
had a problem deploying
to
azure-prod
Share constructor parameter support across threads and cache introspection failures. Refresh the cached support when the native Session class changes. Signed-off-by: Aakash Saravanan <[email protected]>
aakash-saravanan-db
force-pushed
the
aakash-saravanan/cache-kernel-session-signature
branch
from
f927645 to
94698e7
Compare
aakash-saravanan-db
temporarily deployed
to
azure-prod
aakash-saravanan-db
temporarily deployed
to
azure-prod
aakash-saravanan-db
marked this pull request as ready for review
aakash-saravanan-db
temporarily deployed
to
azure-prod
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verdict: 1 Low Looks good, with one low-severity note about test isolation. The cache is checked once without the lock and again under it, it is keyed on the identity of the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Low — The new process-global cache
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThis branch was previously deployed1 inactive deployment
azure-prod
—
94698e71
Deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |