GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ci: port shared engineer bot learnings by vuanhphung · Pull Request #1027 · databricks/databricks-sql-python

Conversation

@vuanhphung

@vuanhphung vuanhphung commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • Other — CI and bot guidance

Description

Port the shared engineer/reviewer bot lessons from databricks/databricks-sql-nodejs#571 and #572: keep changes within maintainer scope, ground findings in evidence, select unit or live tests by behavior, and handle stale reviews. Follow-ups load trusted default-branch config; agents cannot edit their own .bot/ settings.

Sync conflicting bot PRs only when CHANGELOG.md changes are additive # Unreleased entries. Other conflicts receive a maintainer comment. Sync is limited to PRs targeting the default branch.

How is this tested?

  • Unit tests

Passed 18 local changelog/branch-sync cases, YAML parsing, shell syntax checks, and git diff --check. Added a CI workflow to run the sync tests.

Related Tickets & Documents

databricks/databricks-sql-nodejs#571
databricks/databricks-sql-nodejs#572

This PR was created with GitHub MCP.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vuanhphung
ci: port shared engineer bot learnings
17c495b 
Signed-off-by: Vu Anh Phung <[email protected]>
@vuanhphung vuanhphung added the ai-assisted label Nov 12, 2026
@vuanhphung
vuanhphung temporarily deployed to azure-prod November 12, 2026 05:18 — with GitHub Actions Inactive
@vuanhphung
vuanhphung had a problem deploying to azure-prod November 12, 2026 05:18 — with GitHub Actions Failure
peco-review-bot[bot]
peco-review-bot Bot approved these changes Nov 12, 2026
View reviewed changes

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: 1 Low

Looks good. I found one low-severity issue: gh pr list --limit 100 can silently skip bot PRs past the first 100. The sync script handles this repo's # X.Y.Z (date) changelog headings correctly, and the trusted-config and fork gating hold up. Not verified: the engine's --bot flag isn't visible from this repo. Nit: the comment near engineer-bot.yml's live-warehouse env still says the flow always reproduces the bug through tests/e2e, which no longer matches the new choice between unit and e2e tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/scripts/sync-engineer-bot-prs.py
def main():
repo = os.environ['REPO']
target_name = os.environ['DEFAULT_BRANCH']
target = git('rev-parse', f'refs/remotes/origin/{target_name}').stdout.strip()

@peco-review-bot peco-review-bot Bot Nov 12, 2026

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Low — gh pr list --limit 100 silently drops any open engineer-bot PRs beyond the first 100. Those PRs are never synced or commented on, and nothing in the logs says they were skipped. 100 open bot PRs is unlikely today, so this is minor. Still, a quiet cap like this can hide stuck PRs. Two options: raise the limit (for example --limit 1000), or print a ::warning:: when len(prs) equals the limit so it's clear the list was cut off.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@peco-review-bot
peco-review-bot Bot temporarily deployed to azure-prod November 12, 2026 05:25 Inactive
@vuanhphung
vuanhphung temporarily deployed to azure-prod November 12, 2026 05:49 — with GitHub Actions Inactive

This branch was previously deployed

1 inactive deployment
azure-prod — 17c495b5 Deployed Nov 12, 2026 by vuanhphung via test-with-coverage #1125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peco-review-bot peco-review-bot[bot] peco-review-bot[bot] approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ai-assisted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vuanhphung
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.