GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Customization to allow customization of OAuthManager to use another logic to open the login screen in browser by vaimdev · Pull Request #319 · databricks/databricks-sql-python

Conversation

@vaimdev

@vaimdev vaimdev commented Jan 14, 2024

Copy link
Copy Markdown

As mentioned above

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vaimdev added 2 commits January 11, 2024 23:13
@vaimdev
feat (oauth): add custom oauth manager
5b8f720
@vaimdev
fix (auth): remove unused code
530eb3e
@vaimdev
vaimdev requested review from andrefurlan-db, arikfr, susodapop and yunbodeng-db as code owners January 14, 2024 15:02
susodapop
susodapop reviewed Jan 25, 2024
View reviewed changes

@susodapop susodapop left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm closing this pull request.

Given that we already support providing custom credentials providers (example here) we would rather not expose a second way to do the same thing.

If you have any issues constructing your own credentials provider you're welcome to open an issue on this repository or speak with Databricks support.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@susodapop

susodapop commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

Given that we already
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@susodapop susodapop closed this Jan 25, 2024
@peco-engineer-bot peco-engineer-bot Bot mentioned this pull request Sep 6, 2026
[coverage] Conformance findings: CLOUDFETCH-018 #945
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arikfr arikfr Awaiting requested review from arikfr
@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db
@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db
1 more reviewer
@susodapop susodapop susodapop left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vaimdev @susodapop
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.