GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — E2E POC for python telemetry for connect logs by saishreeeee · Pull Request #581 · databricks/databricks-sql-python

Conversation

@saishreeeee

@saishreeeee saishreeeee commented Jun 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Added TelemetryClient and TelemetryClientFactory
Added functionality to export initial telemetry logs

How is this tested?

  • Unit tests
    Added unit tests to check the functionality of telemetry client and telemetry client factory
  • E2E Tests
  • Manually
    Ran a query that triggered the export of initital telemetry log, verified that the log was present in the target table
  • N/A

Related Tickets & Documents

PECOBLR-457

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@saishreeeee
saishreeeee requested review from deeksha-db, gopalldb, jackyhu-db, jayantsing-db, jprakash-db, madhav-db, samikshya-db, shivam2680 and vikrantpuppala as code owners June 3, 2025 02:51
@saishreeeee
saishreeeee had a problem deploying to azure-prod June 3, 2025 02:51 — with GitHub Actions Failure
@saishreeeee
saishreeeee marked this pull request as draft June 3, 2025 02:51
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 3, 2025 04:10 — with GitHub Actions Inactive
@saishreeeee
saishreeeee had a problem deploying to azure-prod June 3, 2025 04:24 — with GitHub Actions Failure
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 3, 2025 04:30 — with GitHub Actions Inactive
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 3, 2025 04:43 — with GitHub Actions Inactive
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 3, 2025 05:05 — with GitHub Actions Inactive
@saishreeeee
saishreeeee marked this pull request as ready for review June 3, 2025 05:05
@saishreeeee saishreeeee self-assigned this Jun 3, 2025
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 3, 2025 05:17 — with GitHub Actions Inactive
vikrantpuppala
vikrantpuppala reviewed Jun 3, 2025
View reviewed changes

@vikrantpuppala vikrantpuppala left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we break down this PR further please? let's start with simple connect logs, then error logs and then latency logs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
saishreeeee reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread src/databricks/sql/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/exc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
saishreeeee had a problem deploying to azure-prod June 3, 2025 06:16 — with GitHub Actions Failure
@saishreeeee
saishreeeee had a problem deploying to azure-prod June 3, 2025 06:21 — with GitHub Actions Failure
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 3, 2025 06:25 — with GitHub Actions Inactive
@saishreeeee saishreeeee changed the title E2E POC for python telemetry for connect + latency + error logs E2E POC for python telemetry for connect logs Jun 3, 2025
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 3, 2025 09:31 — with GitHub Actions Inactive
@saishreeeee
saishreeeee requested a review from vikrantpuppala June 3, 2025 09:57
vikrantpuppala
vikrantpuppala reviewed Jun 3, 2025
View reviewed changes
Comment thread src/databricks/sql/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
saishreeeee force-pushed the PECOBLR-457 branch from 425e633 to 3e8d351 Compare June 4, 2025 06:08
@saishreeeee
saishreeeee had a problem deploying to azure-prod June 4, 2025 06:19 — with GitHub Actions Failure
@github-actions

github-actions Bot commented Jun 4, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
added log statements
5f8dff5 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 6, 2025 06:55 — with GitHub Actions Inactive
@saishreeeee
changed TelemetryClientFactory to a static class and made changes in …
906c187 
…unit tests accordingly

Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 6, 2025 09:40 — with GitHub Actions Inactive
@saishreeeee
added lock in TelemetryClientFactory and specified dict type in _client
f6bd9ad 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 6, 2025 09:52 — with GitHub Actions Inactive
@saishreeeee
changed type of attribute _executor in TelemetryClientFactory
c47bc73 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 6, 2025 09:56 — with GitHub Actions Inactive
@saishreeeee
removed discovery_url
4a2386b 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 8, 2025 14:53 — with GitHub Actions Inactive
vikrantpuppala
vikrantpuppala reviewed Jun 9, 2025
View reviewed changes
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/models/event.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
removed unused params from driver connection params, initialize_telem…
e4c05d1 
…etry_client does not return a telemetry client

Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 9, 2025 05:15 — with GitHub Actions Inactive
@saishreeeee
renamed other as client_cert in auth_mech
bf92c6c 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 9, 2025 05:38 — with GitHub Actions Inactive
jprakash-db
jprakash-db reviewed Jun 9, 2025
View reviewed changes
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/unit/test_telemetry.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/unit/test_telemetry.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/unit/test_telemetry.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/unit/test_telemetry.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
lazy logging, renamed private variables, defined telemetry endpoints …
e218ef9 
…as constants, added callback function while submitting request to executor, changed del to pop

Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee had a problem deploying to azure-prod June 9, 2025 09:31 — with GitHub Actions Failure
@saishreeeee
changed unittest to pytest
9615519 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee had a problem deploying to azure-prod June 9, 2025 09:56 — with GitHub Actions Failure
@saishreeeee
shifted EnumEncoder to telemetry/utils.py
c084846 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee had a problem deploying to azure-prod June 9, 2025 10:10 — with GitHub Actions Failure
@saishreeeee
saishreeeee requested review from jprakash-db and vikrantpuppala June 9, 2025 10:13
@saishreeeee
changed type of _clients in TelemetryClientFactory
7394295 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee had a problem deploying to azure-prod June 9, 2025 13:23 — with GitHub Actions Failure
@saishreeeee
saishreeeee temporarily deployed to azure-prod June 10, 2025 05:02 — with GitHub Actions Inactive
jprakash-db
jprakash-db approved these changes Jun 10, 2025
View reviewed changes

@jprakash-db jprakash-db left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@saishreeeee
saishreeeee merged commit 9dc7d52 into telemetry Jun 10, 2025
@saishreeeee
saishreeeee deleted the PECOBLR-457 branch August 1, 2025 08:10

This branch was previously deployed

1 inactive deployment
azure-prod — 7394295a Deployed Jun 10, 2025 by saishreeeee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jprakash-db jprakash-db jprakash-db approved these changes
@deeksha-db deeksha-db Awaiting requested review from deeksha-db
@samikshya-db samikshya-db Awaiting requested review from samikshya-db
@jackyhu-db jackyhu-db Awaiting requested review from jackyhu-db
@madhav-db madhav-db Awaiting requested review from madhav-db
@gopalldb gopalldb Awaiting requested review from gopalldb
@jayantsing-db jayantsing-db Awaiting requested review from jayantsing-db
@shivam2680 shivam2680 Awaiting requested review from shivam2680
@vikrantpuppala vikrantpuppala Awaiting requested review from vikrantpuppala

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@saishreeeee saishreeeee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@saishreeeee @vikrantpuppala @jprakash-db @moderakh @mohitsingla-db @jackyhu-db @lu-wang-dl @shea-parkes @yunbodeng-db @andrefurlan-db @mattdeekay @sebbegg @itsdani @bkyryliuk @WilliamGentry @dbarrundia-tiger @nithinkdb @unj1m @martinitus
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.