GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Prepare for a release with telemetry on by default by samikshya-db · Pull Request #717 · databricks/databricks-sql-python

Conversation

@samikshya-db

@samikshya-db samikshya-db commented Dec 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other : Release

Description

  • Make telemetry is ON by default to track connection stats. This strictly excludes PII, query text, and results.
  • Prepare for release 4.2.2
  • Also updated the documentation to state that 3.8 is not supported.
  • Updated E2E tests for telemetry to fix the checks (as the telemetry is ON by default now)
  • The tests are now grouped by host ID, so there were additional fixes that were made to make them serial runs rather than parallelise them - to ensure testing is done thoroughly and correctly.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

Manually verified Telemetry use-cases by running it locally and checking on the dashboard too

Screenshot 2025-12-04 at 4 18 50 PM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@samikshya-db
samikshya-db temporarily deployed to azure-prod December 1, 2025 12:45 — with GitHub Actions Inactive
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 1, 2025 12:45 — with GitHub Actions Failure
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 1, 2025 12:51 — with GitHub Actions Failure
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 1, 2025 12:51 — with GitHub Actions Failure
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@samikshya-db
samikshya-db marked this pull request as ready for review December 1, 2025 12:52
@samikshya-db
samikshya-db requested review from jprakash-db and nikhilsuri-db December 1, 2025 12:52
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 1, 2025 12:54 — with GitHub Actions Failure
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 1, 2025 12:54 — with GitHub Actions Failure
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jprakash-db
jprakash-db approved these changes Dec 1, 2025
View reviewed changes

@jprakash-db jprakash-db left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚀 🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vikrantpuppala
vikrantpuppala approved these changes Dec 1, 2025
View reviewed changes

@vikrantpuppala vikrantpuppala left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! please fix changelog style

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
samikshya-db reacted with eyes emoji
All reactions
  • 👀 1 reaction
Comment thread CHANGELOG.md Outdated
- Circuit breaker changes using pybreaker by @nikhilsuri-db in https://github.com/databricks/databricks-sql-python/pull/705
- perf: Optimize telemetry latency logging to reduce overhead by @samikshya-db in https://github.com/databricks/databricks-sql-python/pull/715
- basic e2e test for force telemetry verification by @nikhilsuri-db in https://github.com/databricks/databricks-sql-python/pull/708
- Telemetry is ON by default to track connection stats. (Note : This strictly excludes PII, query text, and results) by @samikshya-db in https://github.com/databricks/databricks-sql-python/pull/717

@vikrantpuppala vikrantpuppala Dec 1, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please format inline with previous changelogs?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
samikshya-db reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@samikshya-db
samikshya-db force-pushed the samikshya-chand_data/release branch from 72486d9 to 70022b5 Compare December 3, 2025 15:25
@samikshya-db
samikshya-db temporarily deployed to azure-prod December 3, 2025 15:25 — with GitHub Actions Inactive
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 3, 2025 15:25 — with GitHub Actions Failure
samikshya-db added 4 commits December 3, 2025 15:27
@samikshya-db
Prepare for a release with telemetry on by default
cd49dab 
Signed-off-by: samikshya-chand_data <[email protected]>
@samikshya-db
Make edits
a04d6da 
Signed-off-by: samikshya-chand_data <[email protected]>
@samikshya-db
Update version
0eda9f0 
Signed-off-by: samikshya-chand_data <[email protected]>
@samikshya-db
Fix CHANGELOG formatting to match previous style
ad01fc2 
Signed-off-by: samikshya-chand_data <[email protected]>
@samikshya-db
samikshya-db force-pushed the samikshya-chand_data/release branch from 70022b5 to ad01fc2 Compare December 3, 2025 15:28
@samikshya-db
samikshya-db temporarily deployed to azure-prod December 3, 2025 15:28 — with GitHub Actions Inactive
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 3, 2025 15:28 — with GitHub Actions Failure
@samikshya-db
Fix telemetry e2e tests for default-enabled behavior
38230c6 
- Update test expectations to reflect telemetry being enabled by default
- Add feature flags cache cleanup in teardown to prevent state leakage between tests
- This ensures each test runs with fresh feature flag state
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 3, 2025 19:11 — with GitHub Actions Failure
@samikshya-db
samikshya-db temporarily deployed to azure-prod December 3, 2025 19:11 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Dec 3, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@samikshya-db
Add wait after connection close for async telemetry submission
6d6e45a
@samikshya-db
samikshya-db temporarily deployed to azure-prod December 3, 2025 20:06 — with GitHub Actions Inactive
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 3, 2025 20:06 — with GitHub Actions Failure
@github-actions

github-actions Bot commented Dec 3, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@samikshya-db
Remove debug logging from telemetry tests
fb8e86d
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 4, 2025 05:07 — with GitHub Actions Failure
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 4, 2025 05:07 — with GitHub Actions Failure
@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nikhilsuri-db
nikhilsuri-db approved these changes Dec 4, 2025
View reviewed changes

@nikhilsuri-db nikhilsuri-db left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@samikshya-db
Mark telemetry e2e tests as serial - must not run in parallel
e898be6 
Root cause: Telemetry tests share host-level client across pytest-xdist workers,
causing test isolation issues with patches. Tests pass serially but fail with -n auto.

Solution: Add @pytest.mark.serial marker. CI needs to run these separately without -n auto.
@samikshya-db
samikshya-db temporarily deployed to azure-prod December 4, 2025 06:24 — with GitHub Actions Inactive
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 4, 2025 06:24 — with GitHub Actions Failure
@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@samikshya-db
Split test execution to run serial tests separately
98aa382 
Telemetry e2e tests must run serially due to shared host-level
telemetry client across pytest-xdist workers. Running with -n auto
causes test isolation issues where futures aren't properly captured.

Changes:
- Run parallel tests with -m 'not serial' -n auto
- Run serial tests with -m 'serial' without parallelization
- Use --cov-append for serial tests to combine coverage
- Mark telemetry e2e tests with @pytest.mark.serial
- Update test expectations for default telemetry behavior
- Add feature flags cache cleanup in test teardown
@samikshya-db
samikshya-db temporarily deployed to azure-prod December 4, 2025 07:35 — with GitHub Actions Inactive
@samikshya-db
samikshya-db had a problem deploying to azure-prod December 4, 2025 07:35 — with GitHub Actions Failure
@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@samikshya-db
Mark telemetry e2e tests as serial - must not run in parallel
5921b08 
The concurrent telemetry e2e test globally patches telemetry methods
to capture events. When run in parallel with other tests via pytest-xdist,
it captures telemetry events from other concurrent tests, causing
assertion failures (expected 60 events, got 88).

All telemetry e2e tests must run serially to avoid cross-test
interference with the shared host-level telemetry client.
@samikshya-db
samikshya-db temporarily deployed to azure-prod December 4, 2025 08:52 — with GitHub Actions Inactive
@samikshya-db
samikshya-db temporarily deployed to azure-prod December 4, 2025 08:52 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@samikshya-db
samikshya-db merged commit d2ae1e8 into main Dec 4, 2025
29 of 30 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@samikshya-db
samikshya-db deleted the samikshya-chand_data/release branch December 4, 2025 10:51

This branch was previously deployed

1 inactive deployment
azure-prod — 5921b084 Deployed Dec 4, 2025 by samikshya-db via test-with-coverage #116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikrantpuppala vikrantpuppala vikrantpuppala approved these changes
@jprakash-db jprakash-db jprakash-db approved these changes
@nikhilsuri-db nikhilsuri-db nikhilsuri-db approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@samikshya-db @vikrantpuppala @jprakash-db @nikhilsuri-db
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.