GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — Fix wheel generation by Viginox · Pull Request #434 · dephell/dephell
This repository was archived by the owner on Jan 12, 2021. It is now read-only.
Conversation
Contributor
Wheel Generation for Packages with src folderFixes issue #391 ProblemPackages containing a src folder above the package folder won't have a working wheel package when building the packages with SolutionAppending the found package dir to the project package path enables the converter to generate a working wheel package for packages with a src folder as well as for packages without one (when there is no src folder, this parameter contains the value MiscAlso fixed a typo in the project_build file.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsFix issue with non working generation of wheel package for projects with src folder structure
orsinium
suggested changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great! That's a good start. As I can see, package_dir keys can have no
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
orsinium
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, it still doesn't work. from pathlib import Path Path().absolute().relative_to('') # ValueError: '/home/gram' does not start with '' Please, include a few test cases. This should help to see what is possible: Thank you for taking care of this. I've done with most of my other projects, so now I'll try to give you feedback faster :)
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
|
I think you can make a project structure in temp_dir fixture, dump it, and then open it with zipfile and check the dumped structure. Like in the tests I shared above. Using the current dir as default is not correct. The project can be located somewhere else. I can't say for sure right now, I'm away from the laptop. However, you can make just tests, and I'll help you with the solution. I understand if you lost here, we definitely need more internal documentation. Right now I'm working on type annotations for everything, it should help a bit :) Off topic: Hmm, why fasthub can't comment on threads? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@orsinium Thanks for the starting point. I'll try to implement some testcases for that. [EDIT] Off topic: Commenting on a thread using fasthub worked for me. Expanded the thread and then there is a separate "Add Commend" filed on the bottom of that thread. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Make generation of wheel package more robust. Using the package_dir content to generate the correct folder structure. This update enables the wheel generation to create the correct file structure in the wheel package according to the package and package_dir variables in the setup.py file.
Update the test file with all possible valid settings for the package_dir file, which can be detected by dephell. All those different directory structures will produce a valid wheel file.
|
While working on this new method to generate the wheel package, I might have encountered a different issue in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
* Fix issue zipfile is not supporting pathlib on pypy * Fix flake8 issues due to not updated local flake8 venv
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.