GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add the op_halt patch for Lua 5.4.4 by jfperusse · Pull Request #29 · devcat-studio/VSCodeLuaDebug

Conversation

@jfperusse

@jfperusse jfperusse commented Mar 30, 2023

Copy link
Copy Markdown

Here's the op_halt patch updated for Lua 5.4.4.

It was tested successfully with vscode-debuggee.lua.

We could confirm the performance gain and that breakpoints and stepping through the code is working fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
simsaens reacted with heart emoji simsaens reacted with eyes emoji
All reactions
  • ❤️ 1 reaction
  • 👀 1 reaction
@jfperusse
Add the op_halt patch for Lua 5.4.4
89eceaf
jfperusse
jfperusse commented Apr 18, 2023
View reviewed changes
Comment thread lua-5.4.4-op_halt/src/lvm.c Outdated
/* LUA_HALT { */
// note: duplicated in ldo.c due to dependency tangle (below requires lopcodes.h and lobject.h)
#define GET_REAL_INSTR(i,p) (GET_OPCODE(i) == OP_HALT ? (p->halts[GETARG_Bx(i)].orig) : (i))
#define vmfetchResume() { \

@jfperusse jfperusse Apr 18, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing random cases where stepping after a halt does not resume properly, as if it ends up offset. This will require further investigation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jfperusse added 2 commits April 17, 2023 22:39
@jfperusse
Fixed incorrect stack issue on halt.
6f70f8b
@jfperusse
Updates for the OP_HALT stack issues.
28fc259
jfperusse
jfperusse commented Sep 3, 2023
View reviewed changes
Comment thread lua-5.4.4-op_halt/src/ldump.c Outdated
dumpByte(D, f->numparams);
dumpByte(D, f->is_vararg);
dumpByte(D, f->maxstacksize);
dumpCode(D, f);

@jfperusse jfperusse Sep 3, 2023

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an issue with the patch and the code ends up being dumped twice.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jfperusse
Fix patch issue breaking string.dump.
d9cc72e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jfperusse
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.