GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use guaranteed binary and source compatibility between releases of Scalafmt by joan38 · Pull Request #260 · diffplug/spotless

Conversation

@joan38

@joan38 joan38 commented Jul 7, 2018

Copy link
Copy Markdown
Contributor

Fix for #252

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joan38 joan38 mentioned this pull request Jul 7, 2018
Proposal to use Scalafmt with the Scala files apache/kafka#4965
Merged
3 tasks
@joan38
joan38 force-pushed the scalafmt-fix branch 2 times, most recently from 1704067 to 9da5575 Compare July 7, 2018 13:02
@nedtwigg

nedtwigg commented Jul 8, 2018

Copy link
Copy Markdown
Member

Looks like the change breaks older versions of scalafmt?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Joan Goyeau
Use guaranteed binary and source compatibility between releases of Sc…
3ae984a 
…alafmt
@joan38
joan38 force-pushed the scalafmt-fix branch from 9da5575 to 3ae984a Compare July 9, 2018 08:52
@joan38

joan38 commented Jul 9, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

This drops the support for scalafmt < v0.7.0-RC1. Is it good enough? It's a pretty old version...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joan38

joan38 commented Jul 9, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I tried to run the tests with gradle test but it doesn't seem to be the way to do and the CONTRIBUTING.md doesn't specify how to run the tests...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joan38 joan38 mentioned this pull request Jul 9, 2018
Config loader methods removed in 1.6.0-RC1 scalameta/scalafmt#1204
Closed
@nedtwigg

nedtwigg commented Jul 9, 2018

Copy link
Copy Markdown
Member

Great! All it needs now is updated CHANGES.md:

  • a summary of the change
  • a link to the newly created PR

If your change only affects a build plugin, and not the lib, then you only need to update the CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and the build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nedtwigg

nedtwigg commented Jul 17, 2018

Copy link
Copy Markdown
Member

bump
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joan38 joan38 mentioned this pull request Jul 24, 2018
Update CHANGE.md #266
Closed
@joan38 @nedtwigg
Update CHANGE.md
a323bc6
@nedtwigg
nedtwigg merged commit 4cbb787 into diffplug:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@joan38 @nedtwigg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.