GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — spotlessApply no longer clobbers file permissions by tglaeser · Pull Request #656 · diffplug/spotless

Conversation

@tglaeser

@tglaeser tglaeser commented Aug 1, 2020 •
edited by nedtwigg
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(edited by @nedtwigg): Fixes #654.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tglaeser added 2 commits July 31, 2020 22:11
@tglaeser
Fix for issue 654 ... copy the original file to the tmp location just…
40e4305 
… to remember the file attributes
@tglaeser
Fix for issue 654 ... fixing java.nio.file.FileAlreadyExistsException
0019984
nedtwigg
nedtwigg requested changes Aug 1, 2020
View reviewed changes

@nedtwigg nedtwigg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! To get this merged, we need two things:

  • a unit test, here is a good example. I would take your word that the code works, but without a unit test I am sure that we will break it again in the future.
  • an entry in this changelog

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTaskImpl.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
tglaeser added 3 commits August 1, 2020 14:07
@tglaeser
Fix for issue 654 ... adding unit test
d537dd4
@tglaeser
Fix for issue 654 ... again, many of the types from Java package 'jav…
63d8579 
…a.nio.file.attribute' are not fs agnostic; as we prefer not having fs specific conditions, we limit ourselvs to basic attribute
@tglaeser
Fix for issue 654 ... add entry to change log
c1747c0
@tglaeser
tglaeser requested a review from nedtwigg August 1, 2020 19:48
nedtwigg added 2 commits August 4, 2020 22:24
@nedtwigg
Revert "Fix for issue 654 ... again, many of the types from Java pack…
597c3dd 
…age 'java.nio.file.attribute' are not fs agnostic; as we prefer not having fs specific conditions, we limit ourselvs to basic attribute"

This reverts commit 63d8579.
@nedtwigg
Revert "Fix for issue 654 ... adding unit test"
c6d63f0 
This reverts commit d537dd4.
@nedtwigg nedtwigg changed the title Fix for issue 654 ... copy the original file to the tmp location just… Fix for issue #654 ... copy the original file to the tmp location just… Aug 5, 2020
@nedtwigg nedtwigg changed the title Fix for issue #654 ... copy the original file to the tmp location just… spotlessApply no longer clobbers file permissions Aug 5, 2020
nedtwigg added 2 commits August 4, 2020 22:41
@nedtwigg
Create a failing test to reproduce diffplug#654.
4c3a399
@nedtwigg
Fix the failing test with @tglaeser's PR.
6fe2c55
@nedtwigg

nedtwigg commented Aug 5, 2020

Copy link
Copy Markdown
Member

I changed the test more explicitly reproduce the original problem you found. Thanks for the find and the fix, this will get released within 48 hrs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nedtwigg
nedtwigg merged commit 6acbfe2 into diffplug:main Aug 5, 2020
@nedtwigg

nedtwigg commented Aug 5, 2020

Copy link
Copy Markdown
Member

Released in plugin-gradle 5.1.1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedtwigg nedtwigg Awaiting requested review from nedtwigg

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Executing gradle spotlessApply changes permission on the changed files from 644 to 755

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tglaeser @nedtwigg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.