GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support for JDBI bind list params. by dylanbaroody · Pull Request #955 · diffplug/spotless

Conversation

@dylanbaroody

@dylanbaroody dylanbaroody commented Oct 1, 2021

Copy link
Copy Markdown
Contributor

JDBI bind list params are in the format: IN(<ids>). Previously the formatter would break these up:

IN(
  < ids >
)

Which breaks the JDBI integration. This will no longer happen in the case that there is a < then a NAME type token then >

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dylanbaroody
jdbi_list_param Add support for JDBI bind list params.
704e6ce 
JDBI bind list params are in the format: `IN(<ids>)`. Previously the formatter would break these up:

```
IN(
  < ids >
)
```

Which breaks the JDBI integration. This will no longer happen in the case that there is a `<` then a NAME type token then `>`
@dylanbaroody dylanbaroody changed the title jdbi_list_param Add support for JDBI bind list params. Add support for JDBI bind list params. Oct 1, 2021
@dylanbaroody
jdbi_list_param Add changelogs
daa9a18
@nedtwigg

nedtwigg commented Oct 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Run spotlessApply to fix CI and this is good :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dylanbaroody
formatting
9c0cf78
@nedtwigg
nedtwigg merged commit 49b3363 into diffplug:main Oct 2, 2021
@nedtwigg nedtwigg mentioned this pull request Oct 2, 2021
Sql Formatter doesn't handle JDBI/JDBC parameters well. #952
Closed
@nedtwigg

nedtwigg commented Oct 2, 2021

Copy link
Copy Markdown
Member

Published in plugin-gradle 5.16.0 and plugin-maven 2.16.0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dylanbaroody @nedtwigg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.