GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: add filter capability to DocumentArray by JoanFM · Pull Request #1051 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

JoanFM commented Jan 25, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Goals:

Add filtering capability with the same QueryLanguage as in v1 docarray.

TODO:

Implement the operators in every Document Type
Test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

github-actions Bot added size/m area/core labels

Jan 25, 2023

JohannesMessner reviewed

Jan 25, 2023

View reviewed changes

Comment thread

docarray/utils/lookup.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

JohannesMessner reviewed

Jan 25, 2023

View reviewed changes

Comment thread

docarray/utils/filter.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added area/testing size/l size/m and removed size/m size/l labels

Jan 26, 2023

JoanFM force-pushed the v2-filter branch from df18a6d to eab4569 Compare

January 26, 2023 12:01

github-actions Bot added size/l and removed size/m labels

Jan 26, 2023

JoanFM force-pushed the v2-filter branch 3 times, most recently from f76d828 to 71aee07 Compare

January 26, 2023 16:50

Jackmin801 and others added 15 commits

January 26, 2023 18:33


          refactor: instances of parametrized tensors are no longer parametrized (

4ce0576

#1026)

* test: add tensor ops tests

Signed-off-by: Jackmin801 <[email protected]>

* feat: instances of parametrized types are not parametrized anymore

Signed-off-by: Jackmin801 <[email protected]>

* test: fix test that have been changed by this feature

Signed-off-by: Jackmin801 <[email protected]>

* refactor: change class name and add comments

Signed-off-by: Jackmin801 <[email protected]>

* test: add tests to make sure isinstance does not do coercion

Signed-off-by: Jackmin801 <[email protected]>

* fix: parametrized isinstance check should not perform coercion

Signed-off-by: Jackmin801 <[email protected]>

* test: add more tests to parametrized class name tests

Signed-off-by: Jackmin801 <[email protected]>

* style: small black fix

Signed-off-by: Jackmin801 <[email protected]>

Signed-off-by: Jackmin801 <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>


          feat(v2): rich display for doc and da (#1043)

6d52497

* feat: add rich display for doc and da

Signed-off-by: anna-charlotte <[email protected]>

* fix: wip plot

Signed-off-by: anna-charlotte <[email protected]>

* fix: wip plot

Signed-off-by: anna-charlotte <[email protected]>

* fix: wip plot

Signed-off-by: anna-charlotte <[email protected]>

* feat: add math package and minmax normalize

Signed-off-by: anna-charlotte <[email protected]>

* fix: summary for document

Signed-off-by: anna-charlotte <[email protected]>

* chore: update poetry lock after rebase

Signed-off-by: anna-charlotte <[email protected]>

* fix: move all from plotmixin to base document

Signed-off-by: anna-charlotte <[email protected]>

* feat: add docs schema summary

Signed-off-by: anna-charlotte <[email protected]>

* feat: add document array summary

Signed-off-by: anna-charlotte <[email protected]>

* fix: display doc within doc

Signed-off-by: anna-charlotte <[email protected]>

* fix: in notebook print docs summary

Signed-off-by: anna-charlotte <[email protected]>

* fix: move summary from da to abstract da

Signed-off-by: anna-charlotte <[email protected]>

* fix: get schema for doc

Signed-off-by: anna-charlotte <[email protected]>

* fix: wip doc summary

Signed-off-by: anna-charlotte <[email protected]>

* fix: wip clean up

Signed-off-by: anna-charlotte <[email protected]>

* test: add test for da pretty print

Signed-off-by: anna-charlotte <[email protected]>

* docs: update note

Signed-off-by: anna-charlotte <[email protected]>

* docs: add some documentation

Signed-off-by: anna-charlotte <[email protected]>

* fix: apply samis suggestion

Signed-off-by: anna-charlotte <[email protected]>

* fix: mypy checks

Signed-off-by: anna-charlotte <[email protected]>

* fix: move to plot mixin

Signed-off-by: anna-charlotte <[email protected]>

* fix: remove redundant line

Signed-off-by: anna-charlotte <[email protected]>

* fix: remove comments

Signed-off-by: anna-charlotte <[email protected]>

* feat: add schema highlighter

Signed-off-by: anna-charlotte <[email protected]>

* fix: add plotmixin to mixin init

Signed-off-by: anna-charlotte <[email protected]>

* fix: adjust da summary

Signed-off-by: anna-charlotte <[email protected]>

* fix: move minmaxnormalize to comp backend

Signed-off-by: anna-charlotte <[email protected]>

* fix: remove redundant lines

Signed-off-by: anna-charlotte <[email protected]>

* fix: add squeeze and detach to comp backend

Signed-off-by: anna-charlotte <[email protected]>

* fix: apply suggestion from code review

Signed-off-by: anna-charlotte <[email protected]>

* refactor: rename iterable attrs

Signed-off-by: anna-charlotte <[email protected]>

* fix: clean up

Signed-off-by: anna-charlotte <[email protected]>

* fix: import

Signed-off-by: anna-charlotte <[email protected]>

* fix: iterate over fields instead of annotations

Signed-off-by: anna-charlotte <[email protected]>

* fix: remove math package since moved to comp backends

Signed-off-by: anna-charlotte <[email protected]>

* refactor: use single quotes

Signed-off-by: anna-charlotte <[email protected]>

* fix: apply suggestions from code review

Signed-off-by: anna-charlotte <[email protected]>

* fix: extract summary to doc summary class

Signed-off-by: anna-charlotte <[email protected]>

* fix: add pretty print for base document

Signed-off-by: anna-charlotte <[email protected]>

* fix: use rich capture instead of string io

Signed-off-by: anna-charlotte <[email protected]>

* fix: add colors for optional and union and use only single quotes

Signed-off-by: anna-charlotte <[email protected]>

* fix: extract display classes to display package

Signed-off-by: anna-charlotte <[email protected]>

* fix: make da not optional in da summary

Signed-off-by: anna-charlotte <[email protected]>

* fix: set _console instead of initializing new one everytime in __str__

Signed-off-by: anna-charlotte <[email protected]>

* fix: put console at module level

Signed-off-by: anna-charlotte <[email protected]>

Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>


          feat: add filter capability to DocumentArray

c006fb3

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          test: add tests on operations on out new types

eaab724

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          test: add equality operator for Text Document

18756e6

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          feat: support python 3.7 (#1055)

399d58b

* feat: add python 3.7 support

Signed-off-by: samsja <[email protected]>

* feat: remove get args

Signed-off-by: samsja <[email protected]>

* fix: fix

Signed-off-by: samsja <[email protected]>

* fix: fix

Signed-off-by: samsja <[email protected]>

* chore(ci): bump ci

Signed-off-by: samsja <[email protected]>

Signed-off-by: samsja <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>


          test: remove some useless tests

c7a7332

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          docs: add better docstring for text

98a75c2

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          test: add bones for filter test

2af8306

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          test: full test driven development

fdbba68

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          refactor: remove useless class

cd0a8ac

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          fix: blackify

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          fix: fix the mypy

d3b1080

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          fix: apply black and some ruff

07fb69f

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          feat: filters ready

3b96083

Signed-off-by: Joan Fontanals Martinez <[email protected]>

JoanFM force-pushed the v2-filter branch from 3cb7e99 to 3b96083 Compare

January 26, 2023 17:34

Joan Fontanals Martinez added 3 commits

January 27, 2023 10:40


          Merge branch 'feat-rewrite-v2' of https://github.com/docarray/docarray …

c1ef8ea

…into v2-filter


          fix: blackify text document

f278c0a


          refactor: fix str

3ea2dcc

JohannesMessner suggested changes

Jan 27, 2023

View reviewed changes

Comment thread

docarray/utils/filter.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

docarray/utils/filter.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

docarray/utils/lookup.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

docarray/utils/lookup.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

docarray/utils/query_parser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

JoanFM requested a review from JohannesMessner

January 27, 2023 10:49


          docs: add docstring to filter

1acb0ec

Signed-off-by: Joan Fontanals Martinez <[email protected]>

JoanFM force-pushed the v2-filter branch from afd38a3 to 1acb0ec Compare

January 27, 2023 10:51

JoanFM marked this pull request as ready for review

January 27, 2023 10:51

JoanFM requested a review from samsja

January 27, 2023 10:52

samsja reviewed

Jan 27, 2023

View reviewed changes

Comment thread

docarray/base_document/document.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

samsja reviewed

Jan 27, 2023

View reviewed changes

Comment thread

docarray/documents/text.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

samsja reviewed

Jan 27, 2023

View reviewed changes

Comment thread

docarray/documents/text.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

samsja reviewed

Jan 27, 2023

View reviewed changes

Comment thread

docarray/utils/lookup.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Joan Fontanals Martinez added 2 commits

January 27, 2023 12:02


          fix: apply suggestions

Signed-off-by: Joan Fontanals Martinez <[email protected]>


          fix: apply suggestions

bd4f797

Signed-off-by: Joan Fontanals Martinez <[email protected]>

JoanFM force-pushed the v2-filter branch from 38a659b to bd4f797 Compare

January 27, 2023 11:11


          refactor: create query language package

63ce5d8

Signed-off-by: Joan Fontanals Martinez <[email protected]>

JoanFM force-pushed the v2-filter branch from 0ad14cf to 824d69a Compare

January 27, 2023 12:00


          test: add tests for query language package

cb91273

Signed-off-by: Joan Fontanals Martinez <[email protected]>

JoanFM force-pushed the v2-filter branch from 824d69a to cb91273 Compare

January 27, 2023 12:13

JoanFM requested a review from samsja

January 27, 2023 12:41


          fix: fix type hints

Signed-off-by: Joan Fontanals Martinez <[email protected]>

JohannesMessner approved these changes

Jan 27, 2023

View reviewed changes

github-actions Bot commented Jan 27, 2023

Copy link

Copy Markdown

📝 Docs are deployed on https://ft-v2-filter--jina-docs.netlify.app 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JoanFM merged commit f870b87 into feat-rewrite-v2

Jan 27, 2023

JoanFM deleted the v2-filter branch

January 27, 2023 13:36

This was referenced Jan 27, 2023

Meta: DocArray v2 Roadmap #780

Closed

v2: filter query languague #1040

Closed

Reviewers

samsja

Awaiting requested review from samsja

1 more reviewer

JohannesMessner

JohannesMessner approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/testing size/l

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

JoanFM commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 27, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JoanFM commented Jan 25, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.