GeezerVison

Problem with poetry:
To display a mesh, we need to install trimesh[easy] instead of only trimesh, because we need scipy and pyglet, too. There is a problem when adding this with poetry though, as the dependency scipy does not support the python versions 3.7 and 3.12:

Because scipy (1.10.0) requires Python <3.12,>=3.8

I guess therefore for now one needs to install trimesh[easy] via pip, such as we do for tensorflow as of right now, yes?

After talking to @samsja we think that it would be nice to not have the .display() method on Document level, but rather type level, so that you call pc_doc.url.display() or pc_doc.tensor.display() instead of pc_doc.display(display_from='url'). For Image, Audio, Video this should work, since we have ImageTensor, ImageUrl and so on.
For Mesh3D however we don't have such a tensor type, and also the display depends on both vertices and face. Same goes for the pointcloud display, which depends on a vertices tensor and optional color tensor.
We could introduce documents for those instead of type, something like:

class VerticesAndFaces(BaseDocument):
    vertices: AnyTensor
    faces: AnyTensor

    def display():
        """display mesh from tensors"""

@JohannesMessner do you have any thought on this?

After talking to @samsja we think that it would be nice to not have the .display() method on Document level, but rather type level, so that you call pc_doc.url.display() or pc_doc.tensor.display() instead of pc_doc.display(display_from='url'). For Image, Audio, Video this should work, since we have ImageTensor, ImageUrl and so on. For Mesh3D however we don't have such a tensor type, and also the display depends on both vertices and face. Same goes for the pointcloud display, which depends on a vertices tensor and optional color tensor. We could introduce documents for those instead of type, something like:

class VerticesAndFaces(BaseDocument):
    vertices: AnyTensor
    faces: AnyTensor

    def display():
        """display mesh from tensors"""

@JohannesMessner do you have any thought on this?

fully agree with putting it at the type level.

I am not 100% convinced with having "magic" documents such as VerticesAndFaces that add display, but probably it's the only way, right?

📝 Docs are deployed on https://ft-feat-display-mesh-v2--jina-docs.netlify.app 🎉