GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: display image audio and video from url and tensor by anna-charlotte · Pull Request #1136 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

anna-charlotte commented Feb 15, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Add display for image, audio, video:

For all the following, add options for when displayed in notebook. Also make possible for remote urls as well as local files.

ImageTensor
ImageUrl
AudioTensor
AudioUrl
VideoTensor
VideoUrl
check and update documentation, if required. See guide

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

github-actions Bot added size/l area/core area/setup area/testing area/typing labels

Feb 15, 2023

anna-charlotte changed the title ~~Feat display img audio vid~~ feat: display image audio and video from url and tensor

Feb 15, 2023

anna-charlotte mentioned this pull request

Feb 15, 2023

Meta: DocArray v2 Roadmap #780

Closed

42 of 47 tasks

anna-charlotte added 23 commits

February 15, 2023 16:18


          feat: display mesh and pointcloud

943d636

Signed-off-by: anna-charlotte <[email protected]>


          chore: update poetry

e9acd12

Signed-off-by: anna-charlotte <[email protected]>


          fix: mypy

c91ab6c

Signed-off-by: anna-charlotte <[email protected]>


          fix: add display from param to mesh and pc display

e979c32

Signed-off-by: anna-charlotte <[email protected]>


          fix: clean up

21fb8ab

Signed-off-by: anna-charlotte <[email protected]>


          fix: mypy

75b33d8

Signed-off-by: anna-charlotte <[email protected]>


          fix: move display from url to mesh and pc url classes

Signed-off-by: anna-charlotte <[email protected]>


          chore: remove pyglet dependency

0129c3a

Signed-off-by: anna-charlotte <[email protected]>


          chore: update pyproject toml

322a718

Signed-off-by: anna-charlotte <[email protected]>


          refactor: copy is notebook function from hubble sdk

05d8461

Signed-off-by: anna-charlotte <[email protected]>


          fix: introduce vertices and faces doc

Signed-off-by: anna-charlotte <[email protected]>


          fix: introduce points and colors class for point cloud

255795c

Signed-off-by: anna-charlotte <[email protected]>


          fix: mypy and tests

db42712

Signed-off-by: anna-charlotte <[email protected]>


          docs: add display example to docs

dca04ce

Signed-off-by: anna-charlotte <[email protected]>


          fix: apply johannes suggestion from review

788f834

Signed-off-by: anna-charlotte <[email protected]>


          fix: apply samis suggestion

57fb1e1

Signed-off-by: anna-charlotte <[email protected]>


          docs: update docstring

3a8dc5e

Signed-off-by: anna-charlotte <[email protected]>


          fix: only display in notebook

38f771d

Signed-off-by: anna-charlotte <[email protected]>


          docs: update docstring

8c31318

Signed-off-by: anna-charlotte <[email protected]>


          chore: get poetry lock file from feat rewrite v2

bbef411

Signed-off-by: anna-charlotte <[email protected]>


          docs: update docstrings

b376ddd

Signed-off-by: anna-charlotte <[email protected]>


          feat: display image from img url and img tensor

016760d

Signed-off-by: anna-charlotte <[email protected]>


          fix: display from image url and from image tensor

f55d811

Signed-off-by: anna-charlotte <[email protected]>

anna-charlotte added 5 commits

February 15, 2023 16:50


          fix: use is notebook from utils instead o f hubble

0a23b52

Signed-off-by: anna-charlotte <[email protected]>


          feat: audio from url

084921b

Signed-off-by: anna-charlotte <[email protected]>


          feat: display video and add pydub to pyproject toml

a949033

Signed-off-by: anna-charlotte <[email protected]>


          wip: remove non notebook

62b58ee

Signed-off-by: anna-charlotte <[email protected]>


          fix: all except video tensor

442dd29

Signed-off-by: anna-charlotte <[email protected]>

anna-charlotte force-pushed the feat-display-img-audio-vid branch from 00e1130 to 442dd29 Compare

February 16, 2023 09:22

anna-charlotte added 4 commits

February 16, 2023 10:23


          fix: mypy check for ipython display

b486b96

Signed-off-by: anna-charlotte <[email protected]>


          fix: mypy check for ipython display

f77d216

Signed-off-by: anna-charlotte <[email protected]>


          feat: add videobytes

ca948f9

Signed-off-by: anna-charlotte <[email protected]>


          Merge remote-tracking branch 'origin/feat-rewrite-v2' into feat-displ…

0dc606c

…ay-img-audio-vid

github-actions Bot added size/m and removed size/l labels

Feb 16, 2023

anna-charlotte added 3 commits

February 16, 2023 15:26


          Merge remote-tracking branch 'origin/feat-rewrite-v2' into feat-displ…

f2c0cff

…ay-img-audio-vid

Signed-off-by: anna-charlotte <[email protected]>


          chore: poetry lock

48a85ba

Signed-off-by: anna-charlotte <[email protected]>


          fix: clean up

9df9df5

Signed-off-by: anna-charlotte <[email protected]>

anna-charlotte marked this pull request as ready for review

February 16, 2023 15:35

anna-charlotte requested review from JohannesMessner and samsja

February 16, 2023 15:37

anna-charlotte mentioned this pull request

Feb 16, 2023

v2: plot image, video, audio, mesh #1127

Closed

2 tasks done

anna-charlotte commented

Feb 16, 2023

View reviewed changes

Comment thread

docarray/typing/tensor/video/video_tensor_mixin.py

		:return: bytes
		"""
		bytes = BytesIO()
		self.save(

anna-charlotte Feb 16, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here mypy complains because "T" has no attribute "save". Why does it no complain though in line 164 (b = self.to_bytes(audio_tensor=audio)), isn't to_bytes() just a method of VideoTensorMixin like save()?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Merge branch 'feat-rewrite-v2' into feat-display-img-audio-vid

e783c14

samsja approved these changes

Feb 17, 2023

View reviewed changes


          fix: mypy check

fe9d3bf

Signed-off-by: anna-charlotte <[email protected]>

github-actions Bot commented Feb 17, 2023

Copy link

Copy Markdown

📝 Docs are deployed on https://ft-feat-display-img-audio-vid--jina-docs.netlify.app 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

samsja merged commit a90850d into feat-rewrite-v2

Feb 17, 2023

samsja deleted the feat-display-img-audio-vid branch

February 17, 2023 08:56

anna-charlotte mentioned this pull request

Feb 20, 2023

DocArray v2 third alpha release note #1153

Closed

Reviewers

JohannesMessner

Awaiting requested review from JohannesMessner

1 more reviewer

samsja

samsja approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/setup area/testing area/typing size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

anna-charlotte commented Feb 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anna-charlotte Feb 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 17, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anna-charlotte commented Feb 15, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

anna-charlotte Feb 16, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.