GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: tensor_type for all DocVec serializations by JohannesMessner · Pull Request #1679 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@JohannesMessner

@JohannesMessner JohannesMessner commented Jun 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

closes #1677

The approach is to create a separate IO Mixin class for DocVec that takes a tensor_type argument for all deserialization operations.

  • proto
  • json
  • pandas
  • bytes
    • pickle-array
  • binary
    • streaming streaming return individual docs, so no tensor_type needed
  • base64
  • documentation

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JohannesMessner
refactor: crate io mixin for docvec with tensor type
5d9b375 
Signed-off-by: Johannes Messner <[email protected]>
@github-actions github-actions Bot added size/l area/core component/array labels Jun 28, 2023
JohannesMessner added 5 commits July 24, 2023 14:35
@JohannesMessner
fix: handle tensor type in load binary
97ae8c4 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
test: add tensor type test from bytes
4fb1092 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
feat: tensor type for from dataframe
520ff6f 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
feat: tensor_type for save and load binary
8a4742a 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
test: add tests for bytes, json, pandas, save load
a5fe7c2 
Signed-off-by: Johannes Messner <[email protected]>
@github-actions github-actions Bot added the area/testing label Jul 24, 2023
@codecov

codecov Bot commented Jul 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage: 37.38% and project coverage change: -57.91% ⚠️

Comparison is base (9c95f3a) 88.56% compared to head (5a7318c) 30.65%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1679       +/-   ##
===========================================
- Coverage   88.56%   30.65%   -57.91%     
===========================================
  Files         155      133       -22     
  Lines        8061     8563      +502     
===========================================
- Hits         7139     2625     -4514     
- Misses        922     5938     +5016
Flag Coverage Δ
docarray 30.65% <37.38%> (-57.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/base_doc/docarray_response.py 0.00% <0.00%> (ø)
docarray/base_doc/mixins/update.py 14.60% <ø> (ø)
docarray/computation/__init__.py 100.00% <ø> (ø)
docarray/computation/abstract_comp_backend.py 76.92% <ø> (ø)
...carray/computation/abstract_numpy_based_backend.py 72.97% <ø> (ø)
docarray/computation/numpy_backend.py 41.48% <ø> (ø)
docarray/computation/tensorflow_backend.py 37.19% <ø> (ø)
docarray/computation/torch_backend.py 45.21% <ø> (ø)
docarray/data/__init__.py 0.00% <ø> (ø)
docarray/data/torch_dataset.py 0.00% <ø> (ø)
... and 87 more

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JohannesMessner added 6 commits July 24, 2023 15:39
@JohannesMessner
test: test for pickle array protocol
c7d66ee 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
refactor: remove outdated comment
057910a 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
fix: some mypy errors
b8c65d2 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
fix: some more mypy fixes
5ca89ee 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
fix: even more mypy
9a61308 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
fix: multiple inheritance problems
ade3026 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
JohannesMessner marked this pull request as ready for review July 25, 2023 14:50
@JohannesMessner
docs: update docs with new arg
5a7318c 
Signed-off-by: Johannes Messner <[email protected]>
@github-actions github-actions Bot added size/xl and removed size/l labels Jul 25, 2023
@github-actions

github-actions Bot commented Jul 25, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the area/docs label Jul 25, 2023
@github-actions

github-actions Bot commented Jul 25, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-tensor-type-deser--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JoanFM
JoanFM approved these changes Jul 26, 2023
View reviewed changes
@JoanFM
JoanFM merged commit efeab90 into main Jul 26, 2023
@JoanFM
JoanFM deleted the tensor-type-deser branch July 26, 2023 02:48
@jupyterjazz jupyterjazz mentioned this pull request Aug 1, 2023
Release Notes v0.37.0 #1740
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@JoanFM JoanFM JoanFM approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/docs area/testing component/array size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tensor_type argument for all DocVec deserializations

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JohannesMessner @JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.