GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor: contains method in the base class by jupyterjazz · Pull Request #1701 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@jupyterjazz

@jupyterjazz jupyterjazz commented Jul 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

small refactoring: put contains method in the base class and ask backends to implement _doc_exists

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jupyterjazz
refactor: abstract contains method
d585d41 
Signed-off-by: jupyterjazz <[email protected]>
@github-actions github-actions Bot added size/m area/core labels Jul 15, 2023
@jupyterjazz jupyterjazz linked an issue Jul 15, 2023 that may be closed by this pull request
feat: doc_exists for each backend #1686
Closed
@jupyterjazz jupyterjazz changed the title refactor: abstract contains method refactor: contains method in the base class Jul 15, 2023
@codecov

codecov Bot commented Jul 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage: 88.88% and project coverage change: +0.05 🎉

Comparison is base (a3f6998) 85.88% compared to head (45fc457) 85.94%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
+ Coverage   85.88%   85.94%   +0.05%     
==========================================
  Files         126      126              
  Lines        7899     7890       -9     
==========================================
- Hits         6784     6781       -3     
+ Misses       1115     1109       -6
Flag Coverage Δ
docarray 85.94% <88.88%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/index/backends/in_memory.py 46.62% <50.00%> (+0.51%) ⬆️
docarray/index/abstract.py 88.64% <71.42%> (-0.10%) ⬇️
docarray/index/backends/elastic.py 90.16% <100.00%> (+0.26%) ⬆️
docarray/index/backends/hnswlib.py 95.27% <100.00%> (+0.35%) ⬆️
docarray/index/backends/qdrant.py 77.72% <100.00%> (+0.24%) ⬆️
docarray/index/backends/redis.py 88.70% <100.00%> (+0.22%) ⬆️
docarray/index/backends/weaviate.py 95.02% <100.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jupyterjazz added 2 commits July 16, 2023 00:24
@jupyterjazz
style: blck and mypy
50251bd 
Signed-off-by: jupyterjazz <[email protected]>
@jupyterjazz
test: resolve base class tests
45fc457 
Signed-off-by: jupyterjazz <[email protected]>
@github-actions github-actions Bot added the area/testing label Jul 15, 2023
@github-actions

github-actions Bot commented Jul 15, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-refactor-docindex-contains--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jupyterjazz
jupyterjazz requested review from JoanFM, JohannesMessner and samsja July 15, 2023 22:38
samsja
samsja approved these changes Jul 17, 2023
View reviewed changes
@jupyterjazz
jupyterjazz merged commit 0ea6846 into main Jul 17, 2023
@jupyterjazz
jupyterjazz deleted the refactor-docindex-contains branch July 17, 2023 08:19
@jupyterjazz jupyterjazz mentioned this pull request Jul 18, 2023
Release Notes v0.36.0 #1707
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoanFM JoanFM Awaiting requested review from JoanFM
@JohannesMessner JohannesMessner Awaiting requested review from JohannesMessner
1 more reviewer
@samsja samsja samsja approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/testing size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: doc_exists for each backend

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jupyterjazz @samsja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.