GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: qdrant unable to see index_name by jupyterjazz · Pull Request #1705 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@jupyterjazz

@jupyterjazz jupyterjazz commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

qdrant doc index does not recognize index_name when passed

from docarray import BaseDoc
from docarray.index import QdrantDocumentIndex

class SimpleSchema(BaseDoc):
    title: str

index = QdrantDocumentIndex[SimpleSchema](index_name='index_name')
print(index.index_name)

will print simpleschema

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jupyterjazz
fix: qdrant can not see index_name
b4de962 
Signed-off-by: jupyterjazz <[email protected]>
@github-actions github-actions Bot added size/s area/core area/testing labels Jul 17, 2023
@jupyterjazz
jupyterjazz requested review from JoanFM, JohannesMessner and samsja July 17, 2023 16:42
@jupyterjazz jupyterjazz linked an issue Jul 17, 2023 that may be closed by this pull request
bug: qdrant index can not recognize index_name #1704
Closed
2 of 6 tasks
@codecov

codecov Bot commented Jul 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage: 89.28% and project coverage change: +0.06 🎉

Comparison is base (a3f6998) 85.88% compared to head (bcc63ec) 85.95%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
+ Coverage   85.88%   85.95%   +0.06%     
==========================================
  Files         126      126              
  Lines        7899     7888      -11     
==========================================
- Hits         6784     6780       -4     
+ Misses       1115     1108       -7
Flag Coverage Δ
docarray 85.95% <89.28%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/index/backends/in_memory.py 46.62% <50.00%> (+0.51%) ⬆️
docarray/index/abstract.py 88.64% <71.42%> (-0.10%) ⬇️
docarray/index/backends/elastic.py 90.16% <100.00%> (+0.26%) ⬆️
docarray/index/backends/hnswlib.py 95.27% <100.00%> (+0.35%) ⬆️
docarray/index/backends/qdrant.py 77.53% <100.00%> (+0.04%) ⬆️
docarray/index/backends/redis.py 88.70% <100.00%> (+0.22%) ⬆️
docarray/index/backends/weaviate.py 95.02% <100.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JoanFM
JoanFM approved these changes Jul 17, 2023
View reviewed changes
@jupyterjazz
test: resolve subindex tests
bcc63ec 
Signed-off-by: jupyterjazz <[email protected]>
@github-actions

github-actions Bot commented Jul 17, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-qdrant-config--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jupyterjazz
jupyterjazz merged commit d2e1858 into main Jul 17, 2023
@jupyterjazz
jupyterjazz deleted the fix-qdrant-config branch July 17, 2023 19:03
@jupyterjazz jupyterjazz mentioned this pull request Jul 18, 2023
Release Notes v0.36.0 #1707
Closed
@JoanFM JoanFM mentioned this pull request Jul 24, 2023
0.36 Nested Collections not stored in a separate Sub Index #1721
Closed
3 of 6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JohannesMessner JohannesMessner Awaiting requested review from JohannesMessner
@samsja samsja Awaiting requested review from samsja
1 more reviewer
@JoanFM JoanFM JoanFM approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/testing size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: qdrant index can not recognize index_name

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jupyterjazz @JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.