GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor: do not recompute every time num_docs by JoanFM · Pull Request #1729 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@JoanFM

@JoanFM JoanFM commented Jul 26, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JoanFM
JoanFM requested a review from jupyterjazz July 26, 2023 11:01
@github-actions github-actions Bot added size/s area/core labels Jul 26, 2023
Joan Fontanals Martinez
refactor: do not recompute every time num_docs
f95b623 
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM
JoanFM force-pushed the fix-num-docs branch from e1efc81 to f95b623 Compare July 26, 2023 11:02
@codecov

codecov Bot commented Jul 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.27% 🎉

Comparison is base (24143a1) 83.21% compared to head (ca5cd2f) 84.48%.

❗ Current head ca5cd2f differs from pull request most recent head dbdc990. Consider uploading reports for the commit dbdc990 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
+ Coverage   83.21%   84.48%   +1.27%     
==========================================
  Files         134      134              
  Lines        8793     8793              
==========================================
+ Hits         7317     7429     +112     
+ Misses       1476     1364     -112
Flag Coverage Δ
docarray 84.48% <100.00%> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/index/backends/hnswlib.py 74.21% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jupyterjazz and others added 2 commits July 26, 2023 13:28
@jupyterjazz
fix: k more than num docs
3ca5780 
Signed-off-by: jupyterjazz <[email protected]>
Joan Fontanals Martinez
Merge branch 'main' of https://github.com/docarray/docarray into fix-…
dbdc990 
…num-docs

Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM
JoanFM force-pushed the fix-num-docs branch from ca5cd2f to dbdc990 Compare July 26, 2023 11:31
jupyterjazz
jupyterjazz reviewed Jul 26, 2023
View reviewed changes
Comment thread docarray/index/backends/hnswlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
jupyterjazz
jupyterjazz suggested changes Jul 26, 2023
View reviewed changes

@jupyterjazz jupyterjazz left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value of k should not be more than number of vectors, otherwise lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Jul 26, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-num-docs--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JoanFM
JoanFM force-pushed the fix-num-docs branch from dbdc990 to b90a9fb Compare July 26, 2023 11:35
jupyterjazz
jupyterjazz approved these changes Jul 26, 2023
View reviewed changes

@jupyterjazz jupyterjazz left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of this issue. Let's add 1-2 sentences in the code to explain why we're doing this

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JoanFM
JoanFM merged commit 19aec21 into main Jul 26, 2023
@jupyterjazz jupyterjazz mentioned this pull request Aug 1, 2023
Release Notes v0.37.0 #1740
Closed
@jupyterjazz jupyterjazz mentioned this pull request Aug 23, 2023
refactor: count number of documents using hnswlib #1759
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jupyterjazz jupyterjazz jupyterjazz approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JoanFM @jupyterjazz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.