GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: add workaround for torch compile by JohannesMessner · Pull Request #1754 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@JohannesMessner

@JohannesMessner JohannesMessner commented Aug 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

fixing torch compilation with TorchTensor is blocked by upstream (see here: #1753), so i'm adding workaround to the docs.

Torch 2.0.1 and poetry don't seem to like each other (see: https://stackoverflow.com/a/76647180) so i had to introduce a bunch of pip uninstall torch / pip install torch to make torch work on the CI.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JohannesMessner
docs: add workaround for torch compile
49eb47b 
Signed-off-by: Johannes Messner <[email protected]>
@github-actions github-actions Bot added size/s area/core area/docs area/typing labels Aug 15, 2023
@codecov

codecov Bot commented Aug 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +1.25% 🎉

Comparison is base (587ab5b) 83.74% compared to head (374abbd) 84.99%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
+ Coverage   83.74%   84.99%   +1.25%     
==========================================
  Files         134      134              
  Lines        8845     8845              
==========================================
+ Hits         7407     7518     +111     
+ Misses       1438     1327     -111
Flag Coverage Δ
docarray 84.99% <ø> (+1.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/typing/tensor/torch_tensor.py 91.08% <ø> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JohannesMessner added 2 commits August 15, 2023 13:07
@JohannesMessner
docs: fix link
ce06855 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
chore: update torch version in lock file to enable torch compile
10d2c54 
Signed-off-by: Johannes Messner <[email protected]>
@github-actions github-actions Bot added size/m and removed size/s labels Aug 15, 2023
@JohannesMessner
ci: install torch manually
731d37d 
Signed-off-by: Johannes Messner <[email protected]>
@github-actions github-actions Bot added area/cicd area/housekeeping labels Aug 16, 2023
@JohannesMessner JohannesMessner linked an issue Aug 24, 2023 that may be closed by this pull request
Document torch.compile workaround #1761
Closed
JohannesMessner added 2 commits August 24, 2023 09:11
@JohannesMessner
fix: revert torch dependecy commits
6c4927a 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
chore: update torch through poetry
fdb0e31 
Signed-off-by: Johannes Messner <[email protected]>
@github-actions github-actions Bot removed area/housekeeping area/cicd labels Aug 24, 2023
@JohannesMessner
ci: uninstall and install torch to hopefully fix stuff
a281ea3 
Signed-off-by: Johannes Messner <[email protected]>
@github-actions github-actions Bot added area/cicd area/housekeeping labels Aug 28, 2023
JohannesMessner and others added 5 commits August 28, 2023 15:57
@JohannesMessner
ci: confirm uninstall
3e93dfd 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
ci: apply torch trick to all tests
dfe4be2 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
ci: torch trick during test setup
c3177e3 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
ci: install torch even for jax and tf tests
5256a07 
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner
Merge branch 'main' into docs-torch-compile
374abbd
@JohannesMessner
JohannesMessner marked this pull request as ready for review August 29, 2023 06:59
@github-actions

github-actions Bot commented Aug 29, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-docs-torch-compile--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JohannesMessner
JohannesMessner requested review from jupyterjazz and samsja August 29, 2023 07:17
samsja
samsja approved these changes Aug 29, 2023
View reviewed changes
@samsja
samsja merged commit cd4854c into main Aug 29, 2023
@samsja
samsja deleted the docs-torch-compile branch August 29, 2023 07:19
@JoanFM JoanFM mentioned this pull request Sep 7, 2023
Release Note #1780
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jupyterjazz jupyterjazz Awaiting requested review from jupyterjazz
1 more reviewer
@samsja samsja samsja approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/cicd area/core area/docs area/housekeeping area/typing size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document torch.compile workaround

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JohannesMessner @samsja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.