GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: casting in reduce before appending by alaeddine-13 · Pull Request #1758 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@alaeddine-13

@alaeddine-13 alaeddine-13 commented Aug 23, 2023

Copy link
Copy Markdown
Member

casts documents to the left side docarray type before appending in reduce

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot added size/xs area/core labels Aug 23, 2023
@codecov

codecov Bot commented Aug 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (46c5dfd) 84.99% compared to head (251b9f9) 85.00%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1758      +/-   ##
==========================================
+ Coverage   84.99%   85.00%   +0.01%     
==========================================
  Files         134      134              
  Lines        8844     8845       +1     
==========================================
+ Hits         7517     7519       +2     
+ Misses       1327     1326       -1
Flag Coverage Δ
docarray 85.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/__init__.py 93.33% <100.00%> (ø)
docarray/utils/reduce.py 95.00% <100.00%> (+0.26%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JoanFM
JoanFM approved these changes Aug 23, 2023
View reviewed changes
@alaeddine-13
fix: casting in reduce before appending
251b9f9 
Signed-off-by: Alaeddine Abdessalem <[email protected]>
@alaeddine-13
alaeddine-13 force-pushed the fix-reduce-casting branch from 3dbecd2 to 251b9f9 Compare August 23, 2023 09:38
@github-actions github-actions Bot added size/s area/docs area/entrypoint area/setup and removed size/xs labels Aug 23, 2023
@github-actions

github-actions Bot commented Aug 23, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-reduce-casting--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JoanFM
JoanFM merged commit 2af8a0c into main Aug 23, 2023
@JoanFM
JoanFM deleted the fix-reduce-casting branch August 23, 2023 11:35
@JoanFM JoanFM mentioned this pull request Sep 7, 2023
Release Note #1780
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@JoanFM JoanFM JoanFM approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core area/docs area/entrypoint area/setup size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@alaeddine-13 @JoanFM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.