GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: improve filtering docstrings by JoanFM · Pull Request #1762 · docarray/docarray

This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Conversation

@JoanFM

@JoanFM JoanFM commented Aug 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As per suggestion in #1749, Some better documentation about the syntax of the filtering query is required

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot added size/xs area/core labels Aug 24, 2023
@codecov

codecov Bot commented Aug 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.68% ⚠️

Comparison is base (2af8a0c) 84.99% compared to head (744443d) 84.31%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1762      +/-   ##
==========================================
- Coverage   84.99%   84.31%   -0.68%     
==========================================
  Files         134      134              
  Lines        8845     8845              
==========================================
- Hits         7518     7458      -60     
- Misses       1327     1387      +60
Flag Coverage Δ
docarray 84.31% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/utils/filter.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Joan Fontanals Martinez
docs: improve filtering docstrings
705abf3 
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM
JoanFM force-pushed the docstring-filter branch from 8c0582f to 705abf3 Compare August 24, 2023 06:39
@JoanFM
JoanFM requested a review from scott-martens August 24, 2023 06:52
scott-martens
scott-martens reviewed Aug 24, 2023
View reviewed changes
Comment thread docarray/utils/filter.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Joan Fontanals @scott-martens
docs: update docarray/utils/filter.py
b0d370b 
Co-authored-by: Scott Martens <[email protected]>
Signed-off-by: Joan Fontanals <[email protected]>
scott-martens
scott-martens approved these changes Aug 24, 2023
View reviewed changes

@scott-martens scott-martens left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Joan Fontanals
Merge branch 'main' into docstring-filter
744443d 
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM
JoanFM force-pushed the docstring-filter branch from 63fc62f to 744443d Compare August 24, 2023 07:43
@github-actions github-actions Bot added size/m and removed size/xs labels Aug 24, 2023
@github-actions

github-actions Bot commented Aug 24, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-docstring-filter--jina-docs.netlify.app 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JoanFM
JoanFM merged commit 61bf9c7 into main Aug 24, 2023
@JoanFM
JoanFM deleted the docstring-filter branch August 24, 2023 07:55
@JoanFM JoanFM mentioned this pull request Sep 7, 2023
Release Note #1780
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@scott-martens scott-martens scott-martens approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area/core size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JoanFM @scott-martens
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.